Re: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-21 Thread Mathieu Desnoyers
* zhangxiliang ([EMAIL PROTECTED]) wrote: > hello, >I have some questions for your patches. > Hi, > > Paravirt and alternatives are always done when SMP is > > inactive, so there is no > > need to use locks. > > > -#ifndef CONFIG_KPROBES > > -#ifdef CONFIG_HOTPLUG_CPU > > - /* It must

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
collect_one_slot(kip, i); } break; } } if (dirty && ++kprobe_garbage_slots > INSNS_PER_PAGE) collect_garbage_slots(); + mutex_unlock(&kprobe_mutex); } > -Original Messag

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
hello, I have some questions for your patches. > Paravirt and alternatives are always done when SMP is > inactive, so there is no > need to use locks. > -#ifndef CONFIG_KPROBES > -#ifdef CONFIG_HOTPLUG_CPU > - /* It must still be possible to apply SMP alternatives. */ > - if (num_p