On Tue, Oct 23, 2007 at 07:41:55PM -0700, David Miller wrote:
> From: "Shane Huang" <[EMAIL PROTECTED]>
> Date: Tue, 23 Oct 2007 18:56:03 +0800
>
> > Also I wonder why the USB MSI patch is not added into kernel at last?
> > Will it lead to other bugs?
>
> Probably someone just needs to be more vo
From: David Miller <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 03:06:22 -0700 (PDT)
> Ok, it seems I've sort-of self-nominated myself to implement
> this so I'll try to work on it tomorrow :-)
I have a working implementation, fully tested on a machine
with Tigon3 ethernet chips that have the quirk
From: "Shane Huang" <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 18:56:03 +0800
> Also I wonder why the USB MSI patch is not added into kernel at last?
> Will it lead to other bugs?
Probably someone just needs to be more vocal and active in pushing it
to the USB subsystem maintainer(s). I've even
> If the pci_intx change will be applied to the SATA driver, can it be
> applied for the ATI USB-HCDs too? See
> http://lkml.org/lkml/2006/12/21/47 for more details. That should help
> most of the ATI MSI quirks. It helped me (Acer Aspire 502x laptop with
> ATI RS480/SB400).
I checked the USB MSI
Daniel Barkalow wrote:
I have a device that supports MSI and INTX-disable, and, with MSI on (and
delivering interrupts successfully) also sends legacy interrupts (on
the IRQ that is no longer associated with the device) unless INTX is
disabled. Without the intx_disable(), the kernel disables th
Krzysztof Halasa wrote:
Jeff Garzik <[EMAIL PROTECTED]> writes:
Note that INTX_DISABLE is a recent addition to PCI.
It's PCI 2.3.
Yes.
Older PCI devices
support neither MSI nor INTX-disable, so make sure such devices don't
creep into your sample.
MSI has been introduced by PCI 2.2 (an
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 06:01:17 -0400
> David Miller wrote:
> > My suggestion is:
...
> Sounds good to me also.
Ok, it seems I've sort-of self-nominated myself to implement
this so I'll try to work on it tomorrow :-)
-
To unsubscribe from this list: send the
David Miller wrote:
My suggestion is:
1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
a flag in the pci_dev.
3) The pci_intx() calls in drivers/pci/msi.c are skipped if this
flag from #2 is set.
4) Add quirk entri
Hi David:
> I think this pretty much sums up the situation accurately.
>
> My suggestion is:
>
> 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
>
> 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
>a flag in the pci_dev.
>
> 3) The pci_intx() calls in drivers/pci/
On Mon, 22 Oct 2007, David Miller wrote:
> My suggestion is:
>
> 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
>
> 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
>a flag in the pci_dev.
>
> 3) The pci_intx() calls in drivers/pci/msi.c are skipped if this
>fl
From: Daniel Barkalow <[EMAIL PROTECTED]>
Date: Mon, 22 Oct 2007 17:31:04 -0400 (EDT)
> It's likewise documented (although maybe arguable in wording) that the
> device shouldn't send legacy interrupts if MSI is in use, regardless of
> INTX_DISABLE, but this also happens in the field.
>
> I thin
From: Krzysztof Halasa <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 01:40:18 +0200
> Jeff Garzik <[EMAIL PROTECTED]> writes:
>
> > In general it is documented that INTX_DISABLE should apply only to
> > INTx# so devices that disable MSI based on that bit are out of spec.
>
> The wording is:
> 10: T
Daniel Barkalow <[EMAIL PROTECTED]> writes:
> 00:05.0 Audio device: nVidia Corporation MCP61 High Definition Audio (rev a2)
>
> will have the same issue, and use a multi-vendor driver.
I think MCP55 HDA did not have such problem, though I may be wrong
(AFAIR it worked with shared IRQ and with MSI
Jeff Garzik <[EMAIL PROTECTED]> writes:
> Note that INTX_DISABLE is a recent addition to PCI.
It's PCI 2.3.
> Older PCI devices
> support neither MSI nor INTX-disable, so make sure such devices don't
> creep into your sample.
MSI has been introduced by PCI 2.2 (and thus PCI-X 1.0) so there may
On Mon, 22 Oct 2007, Jeff Garzik wrote:
> Daniel Barkalow wrote:
> > On Fri, 19 Oct 2007, Jeff Garzik wrote:
> >
> > > Linas Vepstas wrote:
> > > > On Fri, Oct 19, 2007 at 09:17:23PM +0800, Shane Huang wrote:
> > > > > Since we have little experience on PCI and MSI here, we had to try to
> > > >
Daniel Barkalow wrote:
On Fri, 19 Oct 2007, Jeff Garzik wrote:
Linas Vepstas wrote:
On Fri, Oct 19, 2007 at 09:17:23PM +0800, Shane Huang wrote:
Since we have little experience on PCI and MSI here, we had to try to
As someone else pointed out, AMD should have *lots* of people with
pci and ms
On Fri, 19 Oct 2007, Jeff Garzik wrote:
> Linas Vepstas wrote:
> > On Fri, Oct 19, 2007 at 09:17:23PM +0800, Shane Huang wrote:
> > > Since we have little experience on PCI and MSI here, we had to try to
> >
> > As someone else pointed out, AMD should have *lots* of people with
> > pci and msi ex
Hi David
>> When I used "here", I was just meaning our youthful linux southbridge
>> drivers team instead of the whole AMD. Sorry for the confusion to you.
>
> I am still somewhat confused: most people developing the Linux kernel
> are limited to look at this hardware from the outside. They had t
If the pci_intx change will be applied to the SATA driver, can it be
applied for the ATI USB-HCDs too? See
http://lkml.org/lkml/2006/12/21/47 for more details. That should help
most of the ATI MSI quirks. It helped me (Acer Aspire 502x laptop with
ATI RS480/SB400).
> When I used "here", I was jus
On Fri, 2007-10-19 at 16:21 -0400, Jeff Garzik wrote:
> Take a look at tg3.c net driver change
> 2fbe43f6f631dd7ce19fb1499d6164a5bdb34568 which is a similar situation.
>
> However, it may turn out that removing the pci_intx() stuff as a
> general
> rule is easier than quirking these devices, if
Quoting "David G"
> "Here" as in "here at AMD"?! I'm stunned...
> Both AMD and the former ATI should have quite some experience?!
When I used "here", I was just meaning our youthful linux southbridge
drivers team instead of the whole AMD. Sorry for the confusion to you.
Quoting "Linas"
> As so
Linas Vepstas wrote:
On Fri, Oct 19, 2007 at 09:17:23PM +0800, Shane Huang wrote:
Since we have little experience on PCI and MSI here, we had to try to
As someone else pointed out, AMD should have *lots* of people with
pci and msi experience on the payroll. (Folks here buy AMD-designed
pci c
On Fri, Oct 19, 2007 at 09:17:23PM +0800, Shane Huang wrote:
> Since we have little experience on PCI and MSI here, we had to try to
As someone else pointed out, AMD should have *lots* of people with
pci and msi experience on the payroll. (Folks here buy AMD-designed
pci chips ...)
> ONLY
> com
On Thu, 18 Oct 2007, David Miller wrote:
> From: "Shane Huang" <[EMAIL PROTECTED]>
> Date: Thu, 18 Oct 2007 18:37:59 +0800
>
> > Hi Miller:
> >
> > Thank you for your response.
> >
> > The reason why MSIs of these northbridges do not work is still under
> > further debug, we are NOT able to tel
Hi Guys:
> This logic seems backwards, to me. "shoot first, ask questions later"
> To me this it not how to approach this problem.
>
> Once you turn MSI off, there is next to no incentive to fix the
> problem because users aren't running into it any longer.
>
> The only two devices in that bug r
On Thu, Oct 18, 2007 at 04:46:11AM -0700, David Miller wrote:
> From: "Shane Huang" <[EMAIL PROTECTED]>
> Date: Thu, 18 Oct 2007 18:37:59 +0800
>
> > Hi Miller:
> >
> > Thank you for your response.
> >
> > The reason why MSIs of these northbridges do not work is still under
> > further debug, we
From: "Shane Huang" <[EMAIL PROTECTED]>
Date: Thu, 18 Oct 2007 18:37:59 +0800
> Hi Miller:
>
> Thank you for your response.
>
> The reason why MSIs of these northbridges do not work is still under
> further debug, we are NOT able to tell its hardware issue or software
> issue at this time. But
IL PROTECTED]; linux-kernel@vger.kernel.org;
[EMAIL PROTECTED]; Su, Henry; Yang, Libin
> Subject: Re: [patch] PCI: disable MSI on more ATI NorthBridges
>
> From: "Shane Huang" <[EMAIL PROTECTED]>
> Date: Thu, 18 Oct 2007 17:14:36 +0800
>
> > More ATI North Bri
From: "Shane Huang" <[EMAIL PROTECTED]>
Date: Thu, 18 Oct 2007 17:14:36 +0800
> More ATI North Bridges like RS780 can't do MSI like its predecessors
> in linux. Disable MSIs on them.
>
> Signed-off-by: Shane Huang <[EMAIL PROTECTED]>
Can we get some detail as to why these north bridges have to h
29 matches
Mail list logo
