Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-18 Thread Wesley Cheng
On 8/12/2020 11:34 AM, Wesley Cheng wrote: >> >> awesome, thanks a lot for this :-) It's a considerable increase in your >> setup. My only fear here is that we may end up creating a situation >> where we can't allocate enough FIFO for all endpoints. This is, of >> course, a consequence of the fa

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-12 Thread Wesley Cheng
On 8/11/2020 12:12 AM, Felipe Balbi wrote: > > Hi, > > Wesley Cheng writes: >> On 8/10/2020 5:27 AM, Felipe Balbi wrote: >>> Wesley Cheng writes: >>> >>> Hi, >>> Some devices have USB compositions which may require multiple endpoints that support EP bursting. HW defined TX FIFO si

RE: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-12 Thread Peter Chen
> > Thank you for your input. I've actually considered doing some > matching/resizing in > the .match_ep route as well, but it doesn't work well for situations where > multiple > configurations are in play. The reason being that if you look at the > epautoconf APIs, > the configfs driver w

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-12 Thread Wesley Cheng
On 8/11/2020 7:22 PM, Peter Chen wrote: > On Wed, Jun 24, 2020 at 10:31 AM Wesley Cheng wrote: >> >> Some devices have USB compositions which may require multiple endpoints >> that support EP bursting. HW defined TX FIFO sizes may not always be >> sufficient for these compositions. By utilizi

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-11 Thread Peter Chen
On Wed, Jun 24, 2020 at 10:31 AM Wesley Cheng wrote: > > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-11 Thread Alan Stern
On Tue, Aug 11, 2020 at 10:12:41AM +0300, Felipe Balbi wrote: > One possibility around this was suggested above, something along the > lines of: > > usb_gadget_ep_enable_bulk(struct usb_gadget *, struct > usb_ep_alloc_desc *alloc_desc) > > (please think of better names, I'm ho

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-11 Thread Felipe Balbi
Hi, Wesley Cheng writes: > On 8/10/2020 5:27 AM, Felipe Balbi wrote: >> Wesley Cheng writes: >> >> Hi, >> >>> Some devices have USB compositions which may require multiple endpoints >>> that support EP bursting. HW defined TX FIFO sizes may not always be >>> sufficient for these compositions

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-10 Thread Wesley Cheng
On 8/10/2020 5:27 AM, Felipe Balbi wrote: > Wesley Cheng writes: > > Hi, > >> Some devices have USB compositions which may require multiple endpoints >> that support EP bursting. HW defined TX FIFO sizes may not always be >> sufficient for these compositions. By utilizing flexible TX FIFO >

Re: [RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-08-10 Thread Felipe Balbi
Wesley Cheng writes: Hi, > Some devices have USB compositions which may require multiple endpoints > that support EP bursting. HW defined TX FIFO sizes may not always be > sufficient for these compositions. By utilizing flexible TX FIFO > allocation, this allows for endpoints to request the re