Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-30 Thread Vinod
On 30-07-18, 12:46, Peter Ujfalusi wrote: > Vinod, > > On 2018-07-24 14:14, Vinod wrote: > Clients must not mix the two way of handling the metadata. > The set_len() is intended to tell the DMA driver the client provided > metadata size (in MEM_TO_DEV case mostly). > > MEM

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-30 Thread Peter Ujfalusi
Vinod, On 2018-07-24 14:14, Vinod wrote: Clients must not mix the two way of handling the metadata. The set_len() is intended to tell the DMA driver the client provided metadata size (in MEM_TO_DEV case mostly). MEM_TO_DEV flow on client side: get_ptr() fill in t

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-24 Thread Vinod
On 20-07-18, 16:42, Peter Ujfalusi wrote: > > > On 2018-07-19 12:22, Vinod wrote: > > Hi Peter, > > > > On 18-07-18, 13:06, Peter Ujfalusi wrote: > > > +struct dma_async_tx_descriptor; > + > +struct dma_descriptor_metadata_ops { > +int (*attach)(struct dma_async_tx_d

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-20 Thread Peter Ujfalusi
On 2018-07-19 12:22, Vinod wrote: > Hi Peter, > > On 18-07-18, 13:06, Peter Ujfalusi wrote: > +struct dma_async_tx_descriptor; + +struct dma_descriptor_metadata_ops { + int (*attach)(struct dma_async_tx_descriptor *desc, void *data, +size_t len); >>> >

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-19 Thread Vinod
Hi Peter, On 18-07-18, 13:06, Peter Ujfalusi wrote: > >> +struct dma_async_tx_descriptor; > >> + > >> +struct dma_descriptor_metadata_ops { > >> + int (*attach)(struct dma_async_tx_descriptor *desc, void *data, > >> +size_t len); > > > > How does one detach? > > I have not thou

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-18 Thread Peter Ujfalusi
Hi Vinod, On 2018-07-10 08:52, Vinod wrote: > > Hey Peter, > > Sorry for late response on this.. No problem, I was away myself also... > On 01-06-18, 13:24, Peter Ujfalusi wrote: >> If the DMA supports per descriptor metadata it can implement the attach, >> get_ptr/set_len callbacks. >> >> Cli

Re: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-09 Thread Vinod
Hey Peter, Sorry for late response on this.. On 01-06-18, 13:24, Peter Ujfalusi wrote: > If the DMA supports per descriptor metadata it can implement the attach, > get_ptr/set_len callbacks. > > Client drivers must only use either attach or get_ptr/set_len to avoid > miss configuration. > > W

RE: [RFC] dmaengine: Add metadat_ops for dma_async_tx_descriptor

2018-07-02 Thread Radhey Shyam Pandey
> -Original Message- > From: Peter Ujfalusi [mailto:peter.ujfal...@ti.com] > Sent: Friday, June 1, 2018 3:54 PM > To: Radhey Shyam Pandey ; vinod.k...@intel.com > Cc: l...@metafoo.de; michal.si...@xilinx.com; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org; > dan.j.willi...@intel