Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-19 Thread Seth Jennings
On Fri, May 17, 2013 at 05:54:18PM +0100, Mel Gorman wrote: > On Mon, May 13, 2013 at 07:40:02AM -0500, Seth Jennings wrote: > > zswap is a thin compression backend for frontswap. It receives pages from > > frontswap and attempts to store them in a compressed memory pool, resulting > > in > > an e

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-17 Thread Mel Gorman
On Tue, May 14, 2013 at 09:37:08AM -0700, Dan Magenheimer wrote: > > Can I get your ack on this pending the other changes? > > I'd like to hear Mel's feedback about this, but perhaps > a compromise to allow for zswap merging would be to add > something like the following to zswap's Kconfig comment

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-17 Thread Mel Gorman
On Mon, May 13, 2013 at 07:40:02AM -0500, Seth Jennings wrote: > zswap is a thin compression backend for frontswap. It receives pages from > frontswap and attempts to store them in a compressed memory pool, resulting in > an effective partial memory reclaim and dramatically reduced swap device I/O.

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-16 Thread Rik van Riel
On 05/13/2013 08:40 AM, Seth Jennings wrote: zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective partial memory reclaim and dramatically reduced swap device I/O. Additionally, in mos

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-16 Thread Rik van Riel
On 05/16/2013 12:45 PM, Dan Magenheimer wrote: From: Rik van Riel [mailto:r...@redhat.com] I'm not sure we can get it right before people actually start using it for real world setups, instead of just running benchmarks on it. The sooner we get the code out there, where users can play with it

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-16 Thread Dan Magenheimer
odman; > Benjamin Herrenschmidt; Dave > Hansen; Joe Perches; Joonsoo Kim; Cody P Schafer; Hugh Dickens; Paul > Mackerras; linux...@kvack.org; > linux-kernel@vger.kernel.org; de...@driverdev.osuosl.org > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On 05/14/2013 04:18

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Rik van Riel
On 05/14/2013 04:18 PM, Dan Magenheimer wrote: It's unfortunate that my proposed topic for LSFMM was pre-empted by the zsmalloc vs zbud discussion and zswap vs zcache, because I think the real challenge of zswap (or zcache) and the value to distros and end users requires us to get this right BEF

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Rik van Riel
On 05/15/2013 05:36 PM, Dan Magenheimer wrote: If you disagree with any of my arguments earlier in this thread, please say so. Else, please reinforce that the MM subsystem needs to dynamically adapt to a broad range of workloads, which zswap does not (yet) do. Zswap is not simple, it is simpli

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dan Magenheimer
> From: Rik van Riel [mailto:r...@redhat.com] > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On 05/15/2013 03:35 PM, Dan Magenheimer wrote: > >> From: Konrad Rzeszutek Wilk > >> Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > >> > >>> Sorr

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dan Magenheimer
r; Rik van > Riel; Larry Woodman; > Benjamin Herrenschmidt; Joe Perches; Joonsoo Kim; Cody P Schafer; Hugh > Dickens; Paul Mackerras; linux- > m...@kvack.org; linux-kernel@vger.kernel.org; de...@driverdev.osuosl.org > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On 05/15/201

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dan Magenheimer
ik van Riel; Larry Woodman; > Benjamin Herrenschmidt; Dave > Hansen; Joe Perches; Joonsoo Kim; Cody P Schafer; Hugh Dickens; Paul > Mackerras; linux...@kvack.org; > linux-kernel@vger.kernel.org; de...@driverdev.osuosl.org > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > O

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Konrad Rzeszutek Wilk
Seth Jennings wrote: >On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: >> > Sorry, but I don't think that's appropriate for a patch in the MM >subsystem. >> >> I am heading to the airport shortly so this email is a bit hastily >typed. >> >> Perhaps a compromise can be reac

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Rik van Riel
On 05/15/2013 03:35 PM, Dan Magenheimer wrote: From: Konrad Rzeszutek Wilk Subject: Re: [PATCHv11 3/4] zswap: add to mm/ Sorry, but I don't think that's appropriate for a patch in the MM subsystem. I am heading to the airport shortly so this email is a bit hastily typed.

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dave Hansen
On 05/15/2013 01:09 PM, Seth Jennings wrote: > On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: >>> Sorry, but I don't think that's appropriate for a patch in the MM subsystem. >> >> Perhaps a compromise can be reached where this code is merged as a driver >> not a core mm com

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Seth Jennings
On Wed, May 15, 2013 at 02:55:06PM -0400, Konrad Rzeszutek Wilk wrote: > > Sorry, but I don't think that's appropriate for a patch in the MM subsystem. > > I am heading to the airport shortly so this email is a bit hastily typed. > > Perhaps a compromise can be reached where this code is merged a

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dan Magenheimer
> From: Konrad Rzeszutek Wilk > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > > Sorry, but I don't think that's appropriate for a patch in the MM subsystem. > > I am heading to the airport shortly so this email is a bit hastily typed. > > Perhaps a comp

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Konrad Rzeszutek Wilk
> Sorry, but I don't think that's appropriate for a patch in the MM subsystem. I am heading to the airport shortly so this email is a bit hastily typed. Perhaps a compromise can be reached where this code is merged as a driver not a core mm component. There is a high bar to be in the MM - it has

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-15 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On Tue, May 14, 2013 at 01:18:48PM -0700, Dan Magenheimer wrote: > > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > > Subject: Re: [

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 01:18:48PM -0700, Dan Magenheimer wrote: > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > > > > > > > > > +/* The maximum percentage of memory that the compressed p

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On Tue, May 14, 2013 at 09:37:08AM -0700, Dan Magenheimer wrote: > > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > > Subject: Re: [

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > > > > > +/* The maximum percentage of memory that the compressed pool can occupy > > > */ > > > +static unsigned int zswap_max_po

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 09:37:08AM -0700, Dan Magenheimer wrote: > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > > > On Tue, May 14, 2013 at 05:19:19PM +0800, Bob Liu wrote: > > > Hi Seth, >

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCHv11 3/4] zswap: add to mm/ > > On Tue, May 14, 2013 at 05:19:19PM +0800, Bob Liu wrote: > > Hi Seth, > > Hi Bob, thanks for the review! > > > > > > + /* reclaim sp

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Mon, May 13, 2013 at 03:31:42PM -0700, Dan Magenheimer wrote: > > From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > > Subject: [PATCHv11 3/4] zswap: add to mm/ > > > > zswap is a thin compression backend for frontswap. It receives pages from > > frontswap and attempts to store them in

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Seth Jennings
On Tue, May 14, 2013 at 05:19:19PM +0800, Bob Liu wrote: > Hi Seth, Hi Bob, thanks for the review! > > On 05/13/2013 08:40 PM, Seth Jennings wrote: > > zswap is a thin compression backend for frontswap. It receives pages from > > frontswap and attempts to store them in a compressed memory pool,

Re: [PATCHv11 3/4] zswap: add to mm/

2013-05-14 Thread Bob Liu
Hi Seth, On 05/13/2013 08:40 PM, Seth Jennings wrote: > zswap is a thin compression backend for frontswap. It receives pages from > frontswap and attempts to store them in a compressed memory pool, resulting in > an effective partial memory reclaim and dramatically reduced swap device I/O. > > Ad

RE: [PATCHv11 3/4] zswap: add to mm/

2013-05-13 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: [PATCHv11 3/4] zswap: add to mm/ > > zswap is a thin compression backend for frontswap. It receives pages from > frontswap and attempts to store them in a compressed memory pool, resulting in > an effective partial memory reclai