Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2016-04-28 Thread Alex Williamson
es.org; mtosa...@redhat.com; > > eric.au...@linaro.org; k...@vger.kernel.org; iommu@lists.linux- > > foundation.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > > > On Fri, 18 Sep 2015 22:29:

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2016-04-28 Thread Eric Auger
Hi Alex, On 04/26/2016 10:08 PM, Alex Williamson wrote: > On Fri, 18 Sep 2015 22:29:50 +0800 > Feng Wu wrote: > > @@ -360,6 +361,14 @@ static int vfio_msi_set_vector_signal(struct > vfio_pci_device *vdev, >> return ret; >> } >> >> +vdev->ctx[vector].producer.token = trig

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2016-04-26 Thread Wu, Feng
- > foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > On Fri, 18 Sep 2015 22:29:50 +0800 > Feng Wu wrote: > > @@ -360,6 +361,14 @@ static int vfio_msi_set_vector_signal(struct > vfio_pc

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2016-04-26 Thread Alex Williamson
On Fri, 18 Sep 2015 22:29:50 +0800 Feng Wu wrote: @@ -360,6 +361,14 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev, > return ret; > } > > + vdev->ctx[vector].producer.token = trigger; > + vdev->ctx[vector].producer.irq = irq; > + ret = ir

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-22 Thread Eric Auger
aolo Bonzini; Wu, Feng; alex.william...@redhat.com; j...@8bytes.org; >> mtosa...@redhat.com >> Cc: k...@vger.kernel.org; io...@lists.linux-foundation.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer >> >>

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-22 Thread Wu, Feng
redhat.com > Cc: k...@vger.kernel.org; io...@lists.linux-foundation.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > Hi, > On 09/21/2015 03:02 PM, Paolo Bonzini wrote: > > > > > > On 21/09/2015 14:

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Eric Auger
Hi, On 09/21/2015 03:02 PM, Paolo Bonzini wrote: > > > On 21/09/2015 14:53, Wu, Feng wrote: >> I think the point is that we cannot trigger the build of irqbypass >> manager inside KVM or VFIO, we need trigger the build at a high >> level and it should be built before VFIO and KVM. Any

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 14:53, Wu, Feng wrote: >>> > > I think the point is that we cannot trigger the build of irqbypass >>> > > manager inside KVM or VFIO, we need trigger the build at a high >>> > > level and it should be built before VFIO and KVM. Any ideas? >> > >> > We can add virt/Makefile and buil

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Wu, Feng
.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > > > On 21/09/2015 10:56, Wu, Feng wrote: > > Hi Paolo & Alex, > > > > I find that there is a build error in the following two cas

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Wu, Feng
.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > > > On 21/09/2015 13:35, Wu, Feng wrote: > >>> > > I think the point is that we cannot trigger the build of irqbypass > >>&

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 13:35, Wu, Feng wrote: >>> > > I think the point is that we cannot trigger the build of irqbypass >>> > > manager inside KVM or VFIO, we need trigger the build at a high >>> > > level and it should be built before VFIO and KVM. Any ideas? >> > >> > We can add virt/Makefile and buil

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Wu, Feng
.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer > > > > On 21/09/2015 10:56, Wu, Feng wrote: > > Hi Paolo & Alex, > > > > I find that there is a build error in the following two cas

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Paolo Bonzini
On 21/09/2015 10:56, Wu, Feng wrote: > Hi Paolo & Alex, > > I find that there is a build error in the following two cases: > - KVM is configured as 'M' and VFIO as 'Y' > The reason is the build of irqbypass manager is triggered in > arch/x86/kvm/Makefile, and VFIO is built before KVM, hence > it

RE: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-21 Thread Wu, Feng
Hi Paolo & Alex, I find that there is a build error in the following two cases: - KVM is configured as 'M' and VFIO as 'Y' The reason is the build of irqbypass manager is triggered in arch/x86/kvm/Makefile, and VFIO is built before KVM, hence it cannot find the symbols in irqbypass manager. - Dis

Re: [PATCH v9 12/18] vfio: Register/unregister irq_bypass_producer

2015-09-18 Thread Alex Williamson
On Fri, 2015-09-18 at 22:29 +0800, Feng Wu wrote: > This patch adds the registration/unregistration of an > irq_bypass_producer for MSI/MSIx on vfio pci devices. > > Signed-off-by: Feng Wu On nit, Paolo could you please fix the spelling of "registration" in the dev_info, otherwise: Acked-by: Al