Re: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-21 Thread Steven Rostedt
On Thu, 21 Dec 2023 14:51:29 + David Laight wrote: > > I think 1kb units is perfectly fine (patch 15 changes to kb units). The > > interface says its to define the minimal size of the sub-buffer, not the > > actual size. > > I didn't read that far through :-( > Well, this isn't a normal

RE: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-21 Thread David Laight
> I think 1kb units is perfectly fine (patch 15 changes to kb units). The > interface says its to define the minimal size of the sub-buffer, not the > actual size. I didn't read that far through :-( David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, U

Re: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-21 Thread Steven Rostedt
On Thu, 21 Dec 2023 09:17:55 + David Laight wrote: > > Unfortunately, it has to be PAGE_SIZE (and for now it's a power of 2 to > > make masking easy). It's used for splice and will also be used for memory > > mapping with user space. > > Perhaps then the sysctl to set the size should be po

RE: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-21 Thread David Laight
From: Steven Rostedt > Sent: 20 December 2023 13:01 > > On Wed, 20 Dec 2023 08:48:02 + > David Laight wrote: > > > From: Steven Rostedt > > > Sent: 19 December 2023 18:54 > > > From: "Tzvetomir Stoyanov (VMware)" > > > > > > Currently the size of one sub buffer page is global for all buffer

Re: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-20 Thread Steven Rostedt
On Wed, 20 Dec 2023 08:48:02 + David Laight wrote: > From: Steven Rostedt > > Sent: 19 December 2023 18:54 > > From: "Tzvetomir Stoyanov (VMware)" > > > > Currently the size of one sub buffer page is global for all buffers and > > it is hard coded to one system page. In order to introduce c

RE: [PATCH v5 02/15] ring-buffer: Page size per ring buffer

2023-12-20 Thread David Laight
From: Steven Rostedt > Sent: 19 December 2023 18:54 > From: "Tzvetomir Stoyanov (VMware)" > > Currently the size of one sub buffer page is global for all buffers and > it is hard coded to one system page. In order to introduce configurable > ring buffer sub page size, the internal logic should be