RE: RE: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-28 Thread Mohammed, Afzal
Hi Mike, On Sat, Jan 26, 2013 at 04:14:53, Mike Turquette wrote: > I think Paul W. or someone on the TI side should weigh in on your clkdev > entries. My main point is that the actual tree should be modeled and > clocks shouldn't be globbed together unnecessarily. As mentioned in the > other ma

Re: RE: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-25 Thread Mike Turquette
Quoting Mohammed, Afzal (2013-01-25 04:05:44) > Hi Mike, > > On Thu, Jan 24, 2013 at 22:30:44, Mike Turquette wrote: > > Quoting Mohammed, Afzal (2013-01-24 03:36:02) > > > > So there are 3 - LIDD is actually not for present use case, CORE could > > > be clubbed with the divider to have a composi

RE: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-25 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 22:30:44, Mike Turquette wrote: > Quoting Mohammed, Afzal (2013-01-24 03:36:02) > > So there are 3 - LIDD is actually not for present use case, CORE could > > be clubbed with the divider to have a composite clock. And CORE is > > in functional clock path and logic

Re: RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-24 Thread Mike Turquette
Quoting Mohammed, Afzal (2013-01-24 03:36:02) > Hi Mike, > > On Thu, Jan 24, 2013 at 01:52:04, Mike Turquette wrote: > > Quoting Afzal Mohammed (2013-01-23 03:48:56) > > > > +static inline void da8xx_fb_clkc_enable(void) > > > +{ > > > if (lcd_revision == LCD_VERSION_2) > > >

RE: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-24 Thread Mohammed, Afzal
Hi Mike, On Thu, Jan 24, 2013 at 01:52:04, Mike Turquette wrote: > Quoting Afzal Mohammed (2013-01-23 03:48:56) > > +static inline void da8xx_fb_clkc_enable(void) > > +{ > > if (lcd_revision == LCD_VERSION_2) > > lcdc_write(LCD_V2_DMA_CLK_EN | LCD_V2_LIDD_CLK_EN | > >

Re: [PATCH v4 12/12] video: da8xx-fb: CCF clock divider handling

2013-01-23 Thread Mike Turquette
Quoting Afzal Mohammed (2013-01-23 03:48:56) > +static inline void da8xx_fb_clkc_enable(void) > +{ > if (lcd_revision == LCD_VERSION_2) > lcdc_write(LCD_V2_DMA_CLK_EN | LCD_V2_LIDD_CLK_EN | > LCD_V2_CORE_CLK_EN, LCD_CLK_ENABLE_REG); > } >