Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-27 Thread David Hildenbrand
On 27.09.19 08:33, Alastair D'Silva wrote: > On Thu, 2019-09-26 at 09:46 +0200, David Hildenbrand wrote: >> On 26.09.19 09:43, Michal Hocko wrote: >>> On Thu 26-09-19 09:12:50, David Hildenbrand wrote: On 26.09.19 03:34, Alastair D'Silva wrote: > From: Alastair D'Silva > > On Powe

RE: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Alastair D'Silva
On Thu, 2019-09-26 at 09:46 +0200, David Hildenbrand wrote: > On 26.09.19 09:43, Michal Hocko wrote: > > On Thu 26-09-19 09:12:50, David Hildenbrand wrote: > > > On 26.09.19 03:34, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > On PowerPC, the address ranges allocated to O

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Alastair D'Silva
On Thu, 2019-09-26 at 09:53 +0200, Oscar Salvador wrote: > On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > > are allocated from firmware. These address ranges may be higher > > t

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread kbuild test robot
Hi Alastair, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3 next-20190925] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to spec

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Oscar Salvador
On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissa

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 09:40:05, Oscar Salvador wrote: > On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, > > unsigned long nr_pages, > > unsigned long nr, start_sec, end_sec; > >

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:43, Michal Hocko wrote: > On Thu 26-09-19 09:12:50, David Hildenbrand wrote: >> On 26.09.19 03:34, Alastair D'Silva wrote: >>> From: Alastair D'Silva >>> >>> On PowerPC, the address ranges allocated to OpenCAPI LPC memory >>> are allocated from firmware. These address ranges may be

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 11:34:05, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissable address in c

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Michal Hocko
On Thu 26-09-19 09:12:50, David Hildenbrand wrote: > On 26.09.19 03:34, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > > are allocated from firmware. These address ranges may be higher > > than what older kernels permit

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:40, Oscar Salvador wrote: > On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: >> From: Alastair D'Silva >> @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, >> unsigned long nr_pages, >> unsigned long nr, start_sec, end_sec; >> struct

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread Oscar Salvador
On Thu, Sep 26, 2019 at 11:34:05AM +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > @@ -291,6 +307,10 @@ int __ref __add_pages(int nid, unsigned long pfn, > unsigned long nr_pages, > unsigned long nr, start_sec, end_sec; > struct vmem_altmap *altmap = restrictions->altmap; >

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 09:12, David Hildenbrand wrote: > On 26.09.19 03:34, Alastair D'Silva wrote: >> From: Alastair D'Silva >> >> On PowerPC, the address ranges allocated to OpenCAPI LPC memory >> are allocated from firmware. These address ranges may be higher >> than what older kernels permit, as we incre

Re: [PATCH v4] memory_hotplug: Add a bounds check to __add_pages

2019-09-26 Thread David Hildenbrand
On 26.09.19 03:34, Alastair D'Silva wrote: > From: Alastair D'Silva > > On PowerPC, the address ranges allocated to OpenCAPI LPC memory > are allocated from firmware. These address ranges may be higher > than what older kernels permit, as we increased the maximum > permissable address in commit 4