Re: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt

2020-05-30 Thread David Miller
From: Jia He Date: Sat, 30 May 2020 09:38:28 +0800 > When client on the host tries to connect(SOCK_STREAM, O_NONBLOCK) to the > server on the guest, there will be a panic on a ThunderX2 (armv8a server): ... > The race condition is as follows: > Task1Task2 > =

RE: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt()

2020-05-30 Thread Justin He
.kernel.org; > sta...@vger.kernel.org; David S. Miller ; Jakub > Kicinski ; Kaly Xin ; Stefan Hajnoczi > ; Stefano Garzarella > Subject: Re: [PATCH v3] virtio_vsock: Fix race condition in > virtio_transport_recv_pkt() > > > This fixes it by checking sk->sk_shutdown(suggested by Stefa

Re: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv_pkt()

2020-05-30 Thread Markus Elfring
> This fixes it by checking sk->sk_shutdown(suggested by Stefano) after > lock_sock since sk->sk_shutdown is set to SHUTDOWN_MASK under the > protection of lock_sock_nested. How do you think about a wording variant like the following? Thus check the data structure member “sk_shutdown” (suggeste