Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Sergei Shtylyov
Hello. On 07/09/2013 06:07 PM, Sergei Shtylyov wrote: Adds device node for HS USB Host module for AM437x changes from v1 renamed synopsis to snps removed flag tx-fifo-resize Signed-off-by: George Cherian --- arch/arm/boot/dts/am4372.dtsi | 18 ++ 1 file changed, 18

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Sergei Shtylyov
Hello. On 09-07-2013 13:17, George Cherian wrote: Adds device node for HS USB Host module for AM437x changes from v1 renamed synopsis to snps removed flag tx-fifo-resize Signed-off-by: George Cherian --- arch/arm/boot/dts/am4372.dtsi | 18 ++ 1 file changed, 18 inse

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 05:22:43PM +0530, George Cherian wrote: > >>>Another thing: am437x has 4 instances of this IP, why are you adding > >>>only one ? > >>AM437x has got only 2 instances. I have verified only one on HAPS so > >>adding only one. > >weird, on my TRM I see for dwc3 but 2 PHYs.

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread George Cherian
On 7/9/2013 4:57 PM, Felipe Balbi wrote: Hi, On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote: + compatible = "snps,dwc3"; + reg = <0x4839 0xcfff>; weird size, shouldn't this be 0xd000 then the size would be exactly

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 04:51:35PM +0530, George Cherian wrote: > >>+ compatible = "snps,dwc3"; > >>+ reg = <0x4839 0xcfff>; > >weird size, shouldn't this be 0xd000 then the size would be exactly > >52KiB > > okay btw, the reason here i

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread George Cherian
On 7/9/2013 3:50 PM, Felipe Balbi wrote: On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote: Adds device node for HS USB Host module for AM437x changes from v1 renamed synopsis to snps removed flag tx-fifo-resize the patch revision changes don't need to go to the commit log, they

RE: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Mohammed, Afzal
Hi George, On Tue, Jul 09, 2013 at 14:47:26, Cherian, George wrote: > + usb_otg_hs1: am4372_dwc3@4838 { Wouldn't "usb" a better node name ? > + compatible = "ti,am437x-dwc3"; Usage of wild card is discouraged per DT documentation. Regards Afzal -- To unsub

Re: [PATCH v2] arm: dts: AM43x: Add usb_otg_hs node

2013-07-09 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 02:47:26PM +0530, George Cherian wrote: > Adds device node for HS USB Host module for AM437x > > changes from v1 > > renamed synopsis to snps > removed flag tx-fifo-resize the patch revision changes don't need to go to the commit log, they should be placed after the tearl