Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread Viresh Kumar
On 23 May 2018 at 17:17, wrote: > The nvmem will return EPROBE_DEFER, and so will my driver's init. But then no > one will call the init again. So even your driver needs to be registered as a platform driver then and you can create its device from the init function, and add a comment on why you

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
en Boyd > ; Rob Herring ; Mark Rutland > ; Rafael J. Wysocki ; linux- > p...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kernel Mailing List > > Subject: Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver > > On 23 May 2018 at 17:04, wrote: > >

Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread Viresh Kumar
On 23 May 2018 at 17:04, wrote: > You are right. I already checked that in the code... > However, with module_init() the driver fails on reading the nvmem. And why is it failing ?

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
t...@vger.kernel.org; Linux Kernel Mailing List > > Subject: Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver > > On 23 May 2018 at 16:36, wrote: > > > > > >> -Original Message- > >> From: Sudeep Holla > >> Sent: Wednesday, M

Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread Viresh Kumar
cki.net; linux...@vger.kernel.org; devicet...@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: Sudeep Holla >> Subject: Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver >> >> >> >> On 23/05/18 10:40, Ilia Lin wrote: >> > In Certain QC

RE: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread ilialin
rg; > linux-kernel@vger.kernel.org > Cc: Sudeep Holla > Subject: Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver > > > > On 23/05/18 10:40, Ilia Lin wrote: > > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO > > processors, the CPU frequency subse

Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread Sudeep Holla
On 23/05/18 10:40, Ilia Lin wrote: > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > the CPU frequency subset and voltage value of each OPP varies > based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables > defines the voltage and frequency value ba

Re: [PATCH v10 1/2] cpufreq: Add Kryo CPU scaling driver

2018-05-23 Thread Viresh Kumar
On 23-05-18, 12:40, Ilia Lin wrote: > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, > the CPU frequency subset and voltage value of each OPP varies > based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables > defines the voltage and frequency value bas