Re: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

2019-07-24 Thread Corey Minyard
On Wed, Jul 24, 2019 at 03:32:57PM -0400, Asmaa Mnebhi wrote: > ret at line 112 of ipmb_dev_int.c is uninitialized which > results in a warning during build regressions. > This warning was found by build regression/improvement > testing for v5.3-rc1. Applied, thanks for sticking with it :). -core

RE: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

2019-07-24 Thread Asmaa Mnebhi
Ah ok! I put that message on the cover letter. Thanks! I will make an update shortly. -Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Wednesday, July 24, 2019 3:07 PM To: Asmaa Mnebhi Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] Fix uninitialized

Re: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

2019-07-24 Thread Corey Minyard
On Wed, Jul 24, 2019 at 01:45:57PM -0400, Asmaa Mnebhi wrote: > Signed-off-by: Asmaa Mnebhi > Reported-by: Geert Uytterhoeven Sorry to be picky here, but it's considered bad style to have an empty message. I probably wasn't clear before, but you should add some text like "Found by build regress

Re: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

2019-07-24 Thread Corey Minyard
On Wed, Jul 24, 2019 at 10:36:42AM -0400, Asmaa Mnebhi wrote: > Signed-off-by: Asmaa Mnebhi The patch is, of course, fine, but you should add some info about how it was found and a Reported-by: tag. Thanks, -corey > --- > drivers/char/ipmi/ipmb_dev_int.c | 2 +- > 1 file changed, 1 insertion(