Re: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

2019-05-29 Thread Andrew Lunn
On Wed, May 29, 2019 at 05:39:44PM +, Voon, Weifeng wrote: > > > +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg, > > > + u32 *val, u32 *data) > > > +{ > > > + unsigned int reg_shift = priv->hw->mii.reg_shift; > > > + unsigned int reg_mask = pri

RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

2019-05-29 Thread Voon, Weifeng
> > +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg, > > + u32 *val, u32 *data) > > +{ > > + unsigned int reg_shift = priv->hw->mii.reg_shift; > > + unsigned int reg_mask = priv->hw->mii.reg_mask; > > Reverse christmas tree here. You also sho

RE: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support

2019-05-29 Thread Jose Abreu
From: Voon Weifeng Date: Wed, May 29, 2019 at 17:58:23 > +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg, > + u32 *val, u32 *data) > +{ > + unsigned int reg_shift = priv->hw->mii.reg_shift; > + unsigned int reg_mask = priv->hw->mii.reg