Re: [PATCH net-next] r8169: Remove rtl_ocpdr_cond

2012-07-17 Thread Francois Romieu
hayeswang : [...] > rtt min/avg/max/mdev = 0.028/0.040/0.101/0.011 ms, pipe 4, ipg/ewma > 0.021/0.035 > rtt min/avg/max/mdev = 0.151/0.173/0.247/0.020 ms, pipe 4, ipg/ewma > 0.048/0.168 [...] > The attached file is my log. It seems fine. A few percents packet loss at this rate does not exactly

RE: [PATCH net-next] r8169: Remove rtl_ocpdr_cond

2012-07-12 Thread hayeswang
Francois Romieu [mailto:rom...@fr.zoreil.com] [...] > > W/o firmware does not seem to make a difference. > > # ping -qf -l 4 -s 81 -c 60 10.0.3.1 > PING 10.0.3.1 (10.0.3.1) 81(109) bytes of data. > > --- 10.0.3.1 ping statistics --- > 60 packets transmitted, 60 received, 0% packet loss, time 1

Re: [PATCH net-next] r8169: Remove rtl_ocpdr_cond

2012-07-12 Thread Francois Romieu
Francois Romieu : [...] > I'll try again tomorrow evening. W/o firmware does not seem to make a difference. # ping -qf -l 4 -s 81 -c 60 10.0.3.1 PING 10.0.3.1 (10.0.3.1) 81(109) bytes of data. --- 10.0.3.1 ping statistics --- 60 packets transmitted, 60 received, 0% packet loss, time 153ms rtt m

Re: [PATCH net-next] r8169: Remove rtl_ocpdr_cond

2012-07-11 Thread Francois Romieu
Hayes Wang : > No waiting is needed for mac_ocp_{write / read}. And the bit 31 of > OCPDR would not change, so rtl_udelay_loop_wait_high always return > false. That is, the r8168_mac_ocp_read always retuen ~0. (testing with davem's 48ee3569f31d91084dc694fef5517eb782428083) It seemed right at fir