Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-18 Thread David Miller
From: Antoine Tenart Date: Tue, 11 Dec 2018 17:32:28 +0100 > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do so. Th

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Baruch Siach
Hi Antoine, On Wed, Dec 12, 2018 at 03:14:51PM +0100, Antoine Tenart wrote: > On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > > On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > > > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > > > Th

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi, On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > > That is, something like this, right? > > > > > > diff --git a/drivers/net/etherne

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi Stefan, On Tue, Dec 11, 2018 at 09:11:31PM +, Stefan Chulski wrote: > > > > > Are these modes supported on anything except port 0? If not, you should be > > rejecting these, rather than just treating them as RGMII. > > In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on ports

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi Russell, Baruch, On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > That is, something like this, right? > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > b/drivers/net/ethernet/m

RE: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Stefan Chulski
petazz...@bootlin.com; > maxime.chevall...@bootlin.com; gregory.clem...@bootlin.com; > miquel.ray...@bootlin.com; Nadav Haklai ; Stefan > Chulski ; Yan Markman ; > m...@semihalf.com; Baruch Siach > Subject: Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all > ports > >

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Russell King - ARM Linux
On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > That is, something like this, right? > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 125ea99418df..04cb0241ca2b 100644 > --- a/drivers/net/ethernet/marvell/

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Baruch Siach
Hi Russell, Antoine, Russell King - ARM Linux writes: > On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: >> The mvpp2_phylink_validate() function sets all modes that are >> supported by a given PPv2 port. A recent change made all ports to >> advertise they support 10G modes in certa

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Russell King - ARM Linux
On Tue, Dec 11, 2018 at 05:32:28PM +0100, Antoine Tenart wrote: > The mvpp2_phylink_validate() function sets all modes that are > supported by a given PPv2 port. A recent change made all ports to > advertise they support 10G modes in certain cases. This is not true, > as only the port #0 can do so.