RE: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Peng Fan
Hi Jassi, > Subject: Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox > > On Wed, Sep 18, 2019 at 5:00 AM Andre Przywara > wrote: > > > > > > > > > > > > > + }; > > > > > +}; > > > > > > > > If

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 8:58 AM Andre Przywara wrote: > > > > Also there is mbox_chan_txdone() with which a controller driver can > > > signal TX completion explicitly. > > > > > No. Controller can use that only if it has specified txdone_irq, which > > is not the case here. > > I see. So does t

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Andre Przywara
On Wed, 18 Sep 2019 08:31:57 -0500 Jassi Brar wrote: Hi, > On Wed, Sep 18, 2019 at 5:00 AM Andre Przywara wrote: > > > > > > > > > > > > > + }; > > > > > +}; > > > > > > > > If this is the data structure that this mailbox controller uses, I > > > > would expect > > > > this to be docume

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 5:00 AM Andre Przywara wrote: > > > > > > > > > + }; > > > > +}; > > > > > > If this is the data structure that this mailbox controller uses, I would > > > expect > > > this to be documented somewhere, or even exported. > > > > Export this structure in include/linux/mailb

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Andre Przywara
On Wed, 18 Sep 2019 09:09:25 + Peng Fan wrote: Hi, > > Subject: Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox > > > > On Mon, 16 Sep 2019 09:44:41 + > > Peng Fan wrote: > > > > Hi, > > > > looks quite good now, some sm

RE: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Peng Fan
Hi Andre, > Subject: Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox > > On Mon, 16 Sep 2019 09:44:41 + > Peng Fan wrote: > > Hi, > > looks quite good now, some smaller comments below. > I think the only thing left is the "function ID passed by

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-17 Thread Andre Przywara
On Mon, 16 Sep 2019 09:44:41 + Peng Fan wrote: Hi, looks quite good now, some smaller comments below. I think the only thing left is the "function ID passed by the client" topic. Have you tried using this interface using hvc, for instance in KVM or Xen? For instance to provide access to a