RE: [PATCH V3] cpuidle: check dev before usage in cpuidle_use_deepest_state

2017-05-07 Thread Li, Fei
> >> Reviewed-by: Andy Shevchenko > >> Reviewed-by: Koul, Vinod > > > A previous version of this has been applied and I don't see any differences > > in the code changes. > > AFAIR only tags (above) had been extended in v3. Thanks. Yes, for v3 no change in code, and only tags "Reviewed-by" add

Re: [PATCH V3] cpuidle: check dev before usage in cpuidle_use_deepest_state

2017-05-05 Thread Andy Shevchenko
On Sat, May 6, 2017 at 12:33 AM, Rafael J. Wysocki wrote: > On Thursday, May 04, 2017 09:00:52 AM Li, Fei wrote: >> Fixes: bb8313b603eb8 ("cpuidle: Allow enforcing deepest idle state >> selection") >> Signed-off-by: Li, Fei >> Tested-by: Shi, Feng >> Reviewed-by: Andy Shevchenko >> Reviewed-b

Re: [PATCH V3] cpuidle: check dev before usage in cpuidle_use_deepest_state

2017-05-05 Thread Rafael J. Wysocki
On Thursday, May 04, 2017 09:00:52 AM Li, Fei wrote: > In case of there is no cpuidle devices registered, dev will be null, and > panic will be triggered like below; > In this patch, add checking of dev before usage, like that done in > cpuidle_idle_call. > > Panic without fix: > [ 184.961328] B

RE: [PATCH V3] cpuidle: check dev before usage in cpuidle_use_deepest_state

2017-05-04 Thread Li, Fei
On Thursday, May 4, 2017 6:16 PM Daniel Lezcano wrote: > > > > preempt_disable(); > > dev = cpuidle_get_device(); > > - dev->use_deepest_state = enable; > > + if (dev) > > + dev->use_deepest_state = enable; > > > This change is acceptable as a hot fix but the question is 'why is

Re: [PATCH V3] cpuidle: check dev before usage in cpuidle_use_deepest_state

2017-05-04 Thread Daniel Lezcano
On Thu, May 04, 2017 at 09:00:52AM +, Li, Fei wrote: > In case of there is no cpuidle devices registered, dev will be null, and > panic will be triggered like below; > In this patch, add checking of dev before usage, like that done in > cpuidle_idle_call. > > Panic without fix: > [ 184.96132