On Tue, May 28, 2013 at 02:42:22PM +0800, Libo Chen wrote:
> thanks for your review. I will update later.
I agree with the remarks from Sachin.
signature.asc
Description: Digital signature
thanks for your review. I will update later.
Libo
On 2013/5/24 11:19, Sachin Kamat wrote:
> On 23 May 2013 17:30, Libo Chen wrote:
>> peripheral_request_list has got free if any one faild, so no need to free
>> again in err case.
>> aovid this, convert them to devm_* API
>>
>> Signed-off-by: Li
Acked-by: Sonic Zhang
>-Original Message-
>From: Libo Chen [mailto:libo.c...@huawei.com]
>Sent: Thursday, May 23, 2013 8:00 PM
>To: w...@the-dreams.de
>Cc: guz.f...@cn.fujitsu.com; Zhang, Sonic; uclinux-dist-
>de...@blackfin.uclinux.org; linux-...@vger.kernel.org; linux-
>ker...@vger.ker
On 23 May 2013 17:30, Libo Chen wrote:
> peripheral_request_list has got free if any one faild, so no need to free
> again in err case.
> aovid this, convert them to devm_* API
>
> Signed-off-by: Libo Chen
It is a good practice to include changelog while submitting revised
versions of the patch
On 2013/5/24 10:49, Zhang, Sonic wrote:
>> >- iface = kzalloc(sizeof(struct bfin_twi_iface), GFP_KERNEL);
>> >+ iface = devm_kzalloc(&pdev->dev, sizeof(struct bfin_twi_iface),
>> >+ GFP_KERNEL);
>> > if (!iface) {
>> > dev_err(&pdev->dev, "Cannot a
Hi Libo,
>-Original Message-
>From: Libo Chen [mailto:libo.c...@huawei.com]
>Sent: Thursday, May 23, 2013 8:00 PM
>To: w...@the-dreams.de
>Cc: guz.f...@cn.fujitsu.com; Zhang, Sonic; uclinux-dist-
>de...@blackfin.uclinux.org; linux-...@vger.kernel.org; linux-
>ker...@vger.kernel.org; lize..
6 matches
Mail list logo
