RE: [PATCH 7/8] scsi: ufshpb: Add "Cold" regions timer

2021-01-30 Thread Avri Altman
> > + /* region "cold" timer - for host mode */ > > + ktime_t read_timeout; > > + atomic_t read_timeout_expiries; > > Why does this have to be an atomic when you have a lock to protect this > structure already taken? Done. You are right, it is protected by the hpb state lock. Will fi

Re: [PATCH 7/8] scsi: ufshpb: Add "Cold" regions timer

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:16PM +0200, Avri Altman wrote: > In order not to hang on to “cold” regions, we shall inactivate a > region that has no READ access for a predefined amount of time - > READ_TO_MS. For that purpose we shall monitor the active regions list, > polling it on every POLLING_I