RE: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

2014-01-04 Thread Winkler, Tomas
: Re: [PATCH 7/7] Fix uninitialised variable warning in > mei-amt-version.c > > Paul Bolle wrote: > > > But it turns out that call of mei_deinit() isn't needed at all. All of > > the members of mei_cl will be set later in mei_init() and none will be > > used

Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

2014-01-03 Thread David Howells
Paul Bolle wrote: > But it turns out that call of mei_deinit() isn't needed at all. All of > the members of mei_cl will be set later in mei_init() and none will be > used before they are set. So we can simply drop this call of > mei_deinit()." > > Is that analysis (still) correct? It looks true

Re: [PATCH 7/7] Fix uninitialised variable warning in mei-amt-version.c

2014-01-03 Thread Paul Bolle
On Fri, 2014-01-03 at 16:08 +, David Howells wrote: > Fix the following warning: > > Documentation/misc-devices/mei/mei-amt-version.c: In function 'main': > Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning: > 'acmd.fd' is used uninitialized in this function [-Wunini