RE: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend & Resume PM enabling

2014-09-16 Thread Chen, Alvin
> > > Reviewed-by: Hock Leong Kweh > > You still keep that guy as reviewer in a whole series, however I didn't see a > word from him here. How is it possible? In our internal review, he gave me a lot of suggestions. > > + for (i = 0; i < gpio->nr_ports; i++) { > > + unsigned int of

Re: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend & Resume PM enabling

2014-09-16 Thread Shevchenko, Andriy
On Tue, 2014-09-16 at 02:22 -0700, Weike Chen wrote: > This patch enables suspend and resume mode for the power management, and > it is based on Josef Ahmad's previous work. > Few comments below. > Reviewed-by: Hock Leong Kweh You still keep that guy as reviewer in a whole series, however I di

Re: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend & Resume PM enabling

2014-09-16 Thread Andy Shevchenko
On Tue, 2014-09-16 at 02:22 -0700, Weike Chen wrote: > This patch enables suspend and resume mode for the power management, and > it is based on Josef Ahmad's previous work. > Few comments below. > Reviewed-by: Hock Leong Kweh You still keep that guy as reviewer in a whole series, however I di