RE: [PATCH 3/4 v4] GPIO: gpio-dwapb: Support Debounce

2014-09-16 Thread Chen, Alvin
> > + struct bgpio_chip *bgc = to_bgpio_chip(gc); > > + struct dwapb_gpio_port *port = > > + container_of(bgc, struct dwapb_gpio_port, bgc); > > Does it make sense to introduce an inline helper like > > static inline struct dwapb_gpio_port *to_dwapb_gpio_port(struct bgpio_ch

Re: [PATCH 3/4 v4] GPIO: gpio-dwapb: Support Debounce

2014-09-16 Thread Andy Shevchenko
On Tue, 2014-09-16 at 02:22 -0700, Weike Chen wrote: > This patch enables 'debounce' for the designware GPIO, and > it is based on Josef Ahmad's previous work. > > Reviewed-by: Hock Leong Kweh > Reviewed-by: Shevchenko, Andriy This line is wrong. How come? Couple of minor comments below, and a