RE: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-21 Thread David Laight
From: Masahiro Yamada > Sent: 21 December 2020 14:29 > > On Sun, Dec 13, 2020 at 6:47 AM David Laight wrote: > > > > From: Masahiro Yamada > > > Sent: 12 December 2020 16:55 > > > > > > This script was written in awk in spite of the file extension '.sh'. > > > Rewrite it as a shell script. > > ..

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-21 Thread Masahiro Yamada
On Sun, Dec 13, 2020 at 6:47 AM David Laight wrote: > > From: Masahiro Yamada > > Sent: 12 December 2020 16:55 > > > > This script was written in awk in spite of the file extension '.sh'. > > Rewrite it as a shell script. > ... > > +# > > +# Usage: $ ./scripts/ld-version.sh ld > > +# > > +# Print

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-21 Thread Masahiro Yamada
On Sun, Dec 13, 2020 at 2:48 AM Dominique Martinet wrote: > > Masahiro Yamada wrote on Sun, Dec 13, 2020: > > This script was written in awk in spite of the file extension '.sh'. > > Rewrite it as a shell script. > > Wow! I wasn't expecting so much, would have sent some rework after the > upcoming

RE: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-12 Thread David Laight
From: Masahiro Yamada > Sent: 12 December 2020 16:55 > > This script was written in awk in spite of the file extension '.sh'. > Rewrite it as a shell script. ... > +# > +# Usage: $ ./scripts/ld-version.sh ld > +# > +# Print the linker version of `ld' in a 5 or 6-digit form > +# such as `23501' for

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-12 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on kbuild/for-next arm64/for-next/core linus/master v5.10-rc7 next-20201211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-12 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on kbuild/for-next arm64/for-next/core linus/master v5.10-rc7 next-20201211] [cannot apply to mmarek/misc] [If your patch is applied to the wrong git tree, kindly drop us a no

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-12 Thread kernel test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on kbuild/for-next arm64/for-next/core linus/master v5.10-rc7 next-20201211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-12 Thread Dominique Martinet
Masahiro Yamada wrote on Sun, Dec 13, 2020: > This script was written in awk in spite of the file extension '.sh'. > Rewrite it as a shell script. Wow! I wasn't expecting so much, would have sent some rework after the upcoming merge window. Thank you. Some comments below that you can probably ign