RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > Subject: RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > Hi Thomas, > > > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE > mode > > > > > On LS2 platform. > > >

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > > > On LS2 platform. > > > > > > > > And ftm_clocksource_read_up() will adapt to this different. > > > > > > You are missing the point. Why do you want a conditional in a hot > > > path? You know at ini

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread Thomas Gleixner
On Thu, 4 Sep 2014, li.xi...@freescale.com wrote: > > > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > > On LS2 platform. > > > > > > And ftm_clocksource_read_up() will adapt to this different. > > > > You are missing the point. Why do you want a conditional in

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
> > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > On LS2 platform. > > > > And ftm_clocksource_read_up() will adapt to this different. > > You are missing the point. Why do you want a conditional in a hot > path? You know at init time whether the thing is BE or L

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread Thomas Gleixner
On Thu, 4 Sep 2014, li.xi...@freescale.com wrote: > > Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource > > read > > API. > > > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > > > Since the Flextimer device will be implemented i

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > Since the Flextimer device will be implemented in BE mode on > > LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need > &g

Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-03 Thread Thomas Gleixner
On Tue, 26 Aug 2014, Xiubo Li wrote: > Since the Flextimer device will be implemented in BE mode on > LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need > the endianness judgment before doing the mmio. Brilliant. So for every clocksource read you take a conditional. > @@ -238,7 +243,7