RE: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

2014-09-08 Thread Chen, Alvin
> > Since the 'debounce' feature also needs read/write, if we splite this > > patch, then for 'debounce', One patch use readl/writel, and another > > patch change to dwapb_read/write. It seems duplicate since the previous > patch use readl/writel and the fllowing one change it immediately. > > Sinc

Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

2014-09-05 Thread Shevchenko, Andriy
On Fri, 2014-09-05 at 09:35 +, Chen, Alvin wrote: > > Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce > > > > On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote: > > > This patch enables 'debounce' for the designware GPIO, and it is based

RE: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

2014-09-05 Thread Chen, Alvin
> Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce > > On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote: > > This patch enables 'debounce' for the designware GPIO, and it is based > > on Josef Ahmad's previous work. > > Can we split dwap

Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

2014-09-05 Thread Shevchenko, Andriy
On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote: > This patch enables 'debounce' for the designware GPIO, and > it is based on Josef Ahmad's previous work. Can we split dwapb_read/write introducing and changing from this patch to a separate one? > Reviewed-by: Hock Leong Kweh > Reviewed-by: