Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-07-02 Thread Jiri Olsa
On Tue, Jun 30, 2015 at 04:45:18PM +, Liang, Kan wrote: > > > > > On Mon, Jun 29, 2015 at 12:55 PM, wrote: > > > > > > From: Kan Liang > > > > > > Some PMU events have cpumask, e.g uncore events. The cpu list set by > > > user may be incompatible with event's cpumask. > > > This patch will

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-07-02 Thread Jiri Olsa
On Tue, Jun 30, 2015 at 11:42:25AM -0300, a...@kernel.org wrote: > Em Tue, Jun 30, 2015 at 03:54:49PM +0200, Jiri Olsa escreveu: > > On Tue, Jun 30, 2015 at 01:42:49PM +, Liang, Kan wrote: > > > > > +static int perf_evlist__check_evsel_cpus(struct perf_evlist *evlist, > > > > > +struct perf_evs

RE: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread Liang, Kan
> > On Mon, Jun 29, 2015 at 12:55 PM, wrote: > > > > From: Kan Liang > > > > Some PMU events have cpumask, e.g uncore events. The cpu list set by > > user may be incompatible with event's cpumask. > > This patch will check the user defined cpu list. If the incompatible > > cpu is found, it will

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread Stephane Eranian
On Mon, Jun 29, 2015 at 12:55 PM, wrote: > > From: Kan Liang > > Some PMU events have cpumask, e.g uncore events. The cpu list set by > user may be incompatible with event's cpumask. > This patch will check the user defined cpu list. If the incompatible cpu > is found, it will warn the user and d

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread a...@kernel.org
Em Tue, Jun 30, 2015 at 03:54:49PM +0200, Jiri Olsa escreveu: > On Tue, Jun 30, 2015 at 01:42:49PM +, Liang, Kan wrote: > > > > +static int perf_evlist__check_evsel_cpus(struct perf_evlist *evlist, > > > > +struct perf_evsel *evsel) { > > > > + const struct cpu_map *cpus = evlist->cpus; >

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread Jiri Olsa
On Tue, Jun 30, 2015 at 01:42:49PM +, Liang, Kan wrote: > > > > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index > > > 6cfdee6..f179379 100644 > > > --- a/tools/perf/util/evlist.c > > > +++ b/tools/perf/util/evlist.c > > > @@ -1101,6 +1101,71 @@ int perf_evlist__mmap(s

RE: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread Liang, Kan
> > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index > > 6cfdee6..f179379 100644 > > --- a/tools/perf/util/evlist.c > > +++ b/tools/perf/util/evlist.c > > @@ -1101,6 +1101,71 @@ int perf_evlist__mmap(struct perf_evlist > *evlist, unsigned int pages, > > return perf_evlis

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread Jiri Olsa
On Mon, Jun 29, 2015 at 03:55:35PM -0400, kan.li...@intel.com wrote: SNIP > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 6cfdee6..f179379 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -1101,6 +1101,71 @@ int perf_evlist__mmap(struct perf