Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Pekka Enberg
Hi Michael, On 5/21/07, Hennerich, Michael <[EMAIL PROTECTED]> wrote: During initcalls: con_init is called, and returns because of !display_desc. [snip] Aah, I missed that bit. On 5/21/07, Hennerich, Michael <[EMAIL PROTECTED]> wrote: I don't see where vc_cons[].d in between there is initia

RE: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Hennerich, Michael
e is initialized. >-Original Message- >From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Pekka >Enberg >Sent: Montag, 21. Mai 2007 14:51 >To: Hennerich, Michael >Cc: Bryan Wu; [EMAIL PROTECTED]; [EMAIL PROTECTED]; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH

Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Pekka Enberg
On 5/21/07, Hennerich, Michael <[EMAIL PROTECTED]> wrote: With CONFIG_VT (drivers/char/vt.c) enabled and a USB HID keyboard connected, we were seeing bad pointer dereferences in drivers/char/keyboard.c In function kbd_keycode vc_cons[fg_console].d was un-initialized. On 5/21/07, Pekka Enberg <

Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Pekka Enberg
On 5/21/07, Hennerich, Michael <[EMAIL PROTECTED]> wrote: I was fixing this issue some time ago. [snip] Makes sense. Please consider adding this to the changelog. Thanks. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

RE: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Hennerich, Michael
;From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Pekka >Enberg >Sent: Montag, 21. Mai 2007 13:40 >To: Bryan Wu >Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux- >[EMAIL PROTECTED]; Michael Hennerich >Subject: Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keybo

Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel

2007-05-21 Thread Pekka Enberg
Hi Bryan, On 5/21/07, Bryan Wu <[EMAIL PROTECTED]> wrote: +#ifdef CONFIG_DUMMY_CONSOLE + conswitchp = &dummy_con; +#endif cclk = get_cclk(); sclk = get_sclk(); This patch has no changelog. While it is probably apparent to you why this fixes a crash when using an USB keybo