Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-11 Thread Jeff Moyer
Jerry Hoemann writes: > The ndn_pkg.buf struct uses a flexible array definition. This is in C99. > An explicit zero length array is a gcc extension that has been around much > longer. They behave in a similar fashion, but aren't identical. In my > limited use they behave the same. I could sw

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Dan Williams
On Tue, Nov 10, 2015 at 4:44 PM, Jerry Hoemann wrote: > On Tue, Nov 10, 2015 at 03:26:38PM -0500, Jeff Moyer wrote: [..] >> I see. I misread that, because you didn't actually make buf a zero >> length array (see the structure definition quoted above). I guess you >> meant to write this: >> >>

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 03:26:38PM -0500, Jeff Moyer wrote: > > > > The definition for the IOCTLs are in a user space application. > > These aren't required in the kernel as the kernel is only a > > pass thru. > > OK, I don't see the harm in including it in the kernel headers, but I'm > not going

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Dan Williams
On Tue, Nov 10, 2015 at 12:53 PM, Linda Knippers wrote: > On 11/10/2015 3:27 PM, Dan Williams wrote: >> >> On Tue, Nov 10, 2015 at 11:49 AM, Jerry Hoemann >> wrote: >>> >>> On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: Jerry Hoemann writes: > Add IOCTL type 'P' t

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 12:04:22PM -0700, Elliott, Robert (Persistent Memory) wrote: > > -Original Message- > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > > Hoemann, Jerry > > Sent: Friday, November 6, 2015 4:27 PM > > Subject: [PATCH 1/4] nvdimm: Add wrap

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Linda Knippers
On 11/10/2015 3:27 PM, Dan Williams wrote: On Tue, Nov 10, 2015 at 11:49 AM, Jerry Hoemann wrote: On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: Jerry Hoemann writes: Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. Can't you just make passthrough a separate command? If yo

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Dan Williams
On Tue, Nov 10, 2015 at 11:49 AM, Jerry Hoemann wrote: > On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: >> Jerry Hoemann writes: >> >> > Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. >> >> Can't you just make passthrough a separate command? If you actually add > > There are mul

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jeff Moyer
Jerry Hoemann writes: > On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: >> Jerry Hoemann writes: >> >> > Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. >> >> Can't you just make passthrough a separate command? If you actually add > > There are multiple conflicting NVDIMM _DSM

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jerry Hoemann
On Tue, Nov 10, 2015 at 12:51:59PM -0500, Jeff Moyer wrote: > Jerry Hoemann writes: > > > Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add There are multiple conflicting NVDIMM _DSM running around, they are "device s

RE: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Hoemann, Jerry > Sent: Friday, November 6, 2015 4:27 PM > Subject: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru. ... > diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndct

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Dan Williams
On Tue, Nov 10, 2015 at 9:51 AM, Jeff Moyer wrote: > Jerry Hoemann writes: > >> Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add > the ioctl definition for passthrough (which you didn't do for some > reason?), it looks

Re: [PATCH 1/4] nvdimm: Add wrapper for IOCTL pass thru.

2015-11-10 Thread Jeff Moyer
Jerry Hoemann writes: > Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. Can't you just make passthrough a separate command? If you actually add the ioctl definition for passthrough (which you didn't do for some reason?), it looks odd: #define ND_IOCTL_PASSTHRU_IOWR(NVDIMM_TYPE_PASST