Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

2015-11-18 Thread Ian Abbott
On 18/11/15 16:45, Hartley Sweeten wrote: On Wednesday, November 18, 2015 9:42 AM, Ian Abbott wrote: On 16/11/15 17:18, Ranjith Thangavel wrote: [snip] -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4) -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4) -#define DMM32AT_AI_CFG_SCINT_10US (2

RE: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

2015-11-18 Thread Hartley Sweeten
On Wednesday, November 18, 2015 9:42 AM, Ian Abbott wrote: > On 16/11/15 17:18, Ranjith Thangavel wrote: [snip] >> -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4) >> -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4) >> -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4) >> -#define DMM32AT_AI_CFG_SCINT_5US

Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

2015-11-18 Thread Ian Abbott
On 16/11/15 17:18, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator, usleep_range is preferred over udelay - coding style issue This patch doesn't use usleep_range(), so the description is inaccurate. Signed-off-by: Ranjith Thangavel --- dr

Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

2015-11-17 Thread Sudip Mukherjee
On Mon, Nov 16, 2015 at 10:48:27PM +0530, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator, usleep_range is preferred over > udelay - coding style issue > > Signed-off-by: Ranjith Thangavel > --- I am not seeing any change related to udelay. C