Re: [PATCH 02/10] x86/efi: Return error status if mapping EFI regions fail

2019-02-08 Thread Ard Biesheuvel
On Mon, 4 Feb 2019 at 23:29, Prakhya, Sai Praneeth wrote: > > > > > efi_map_region() creates VA mappings for an given EFI region using > > > > any one of the two helper functions (namely __map_region() and > > old_map_region()). > > > > These helper functions *could* fail while creating mappings a

RE: [PATCH 02/10] x86/efi: Return error status if mapping EFI regions fail

2019-02-04 Thread Prakhya, Sai Praneeth
> > > efi_map_region() creates VA mappings for an given EFI region using > > > any one of the two helper functions (namely __map_region() and > old_map_region()). > > > These helper functions *could* fail while creating mappings and > > > presently their return value is not checked. Not checking fo

Re: [PATCH 02/10] x86/efi: Return error status if mapping EFI regions fail

2019-02-03 Thread Ard Biesheuvel
On Mon, 4 Feb 2019 at 08:18, Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > From: Sai Praneeth Prakhya > > > > efi_map_region() creates VA mappings for an given EFI region using any one > > of the two helper functions (namely __map_region() and old_map_region()). > > These helper functio

Re: [PATCH 02/10] x86/efi: Return error status if mapping EFI regions fail

2019-02-03 Thread Ingo Molnar
* Ingo Molnar wrote: > Note that I also fixed up the grammar and readability of the changelog - > see the updated version below. > > Thanks, > > Ingo > > => > Subject: x86/efi: Return error status if mapping of EFI regions fails > From: Ard Biesheuvel > Date: Sat, 2 Feb 2

Re: [PATCH 02/10] x86/efi: Return error status if mapping EFI regions fail

2019-02-03 Thread Ingo Molnar
* Ard Biesheuvel wrote: > From: Sai Praneeth Prakhya > > efi_map_region() creates VA mappings for an given EFI region using any one > of the two helper functions (namely __map_region() and old_map_region()). > These helper functions *could* fail while creating mappings and presently > their r