Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Fenghua Yu
On Wed, Oct 17, 2018 at 11:04 AM Moger, Babu wrote: > > Hi Fenghua, > My few comments. > > On 10/17/2018 09:40 AM, Moger, Babu wrote: > > On 10/16/2018 03:32 PM, Fenghua Yu wrote: > >>> From: Moger, Babu [mailto:babu.mo...@amd.com] > >>> On 10/16/2018 11:56 AM, Fenghua Y

RE: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Prakhya, Sai Praneeth
> > For (Intel) Memory Bandwidth features like MBA and MBM, perf iMC > > (Integrated Memory Controller) is used for validation. As a part of > > test, we run a benchmark (eg: fill_buf) and get memory bandwidth > > values from MBM and iMC and verify if the difference between both the > reported valu

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Moger, Babu
On 10/17/2018 12:28 PM, Prakhya, Sai Praneeth wrote: >>> No, the selftest in this patch set will not replace intel-cmt-cat or >>> vice versa. >>> >>> The selftest in this patch set has a different purpose from intel-cmt-cat: >>> the selftest is a test tool which validates resctrl functionalities

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Moger, Babu
On 10/17/2018 01:03 PM, Moger, Babu wrote: > Hi Fenghua, > My few comments. > > On 10/17/2018 09:40 AM, Moger, Babu wrote: >> >> >> On 10/16/2018 03:32 PM, Fenghua Yu wrote: From: Moger, Babu [mailto:babu.mo...@amd.com] On 10/16/2018 11:56 AM, Fenghua Yu wrote: > With more and mo

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Moger, Babu
Hi Fenghua, My few comments. On 10/17/2018 09:40 AM, Moger, Babu wrote: > > > On 10/16/2018 03:32 PM, Fenghua Yu wrote: >>> From: Moger, Babu [mailto:babu.mo...@amd.com] >>> On 10/16/2018 11:56 AM, Fenghua Yu wrote: With more and more resctrl features are being added by Intel, AMD and >>

RE: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Prakhya, Sai Praneeth
> > No, the selftest in this patch set will not replace intel-cmt-cat or > > vice versa. > > > > The selftest in this patch set has a different purpose from intel-cmt-cat: > > the selftest is a test tool which validates resctrl functionalities > > while intel-cmt-cat is mainly a utility that provid

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-17 Thread Moger, Babu
On 10/16/2018 03:32 PM, Fenghua Yu wrote: >> From: Moger, Babu [mailto:babu.mo...@amd.com] >> On 10/16/2018 11:56 AM, Fenghua Yu wrote: >>> With more and more resctrl features are being added by Intel, AMD and >>> ARM, a test tool is becoming more and more useful to validate that >>> both hard

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-16 Thread Fenghua Yu
> From: Moger, Babu [mailto:babu.mo...@amd.com] > On 10/16/2018 11:56 AM, Fenghua Yu wrote: > > With more and more resctrl features are being added by Intel, AMD and > > ARM, a test tool is becoming more and more useful to validate that > > both hardware and software functionalities work as expe

Re: [PATCH 0/7] selftests/resctrl: Add resctrl selftest

2018-10-16 Thread Moger, Babu
Hi Fenghua, On 10/16/2018 11:56 AM, Fenghua Yu wrote: > With more and more resctrl features are being added by Intel, AMD > and ARM, a test tool is becoming more and more useful to validate > that both hardware and software functionalities work as expected. I like the initiative here. It is alwa