Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-10 Thread Felipe Balbi
hi, Roger Quadros writes: >>> Peter Chen writes: On 19-10-07 07:39:11, Pawel Laszczak wrote: > Patch fixes issue with Halt Endnpoint Test observed %s/Endnpoint/Endpoint > > during using g_zero > driver as DUT. Bug occurred only on some testing board. >>

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-09 Thread Roger Quadros
Pawel, On 09/10/2019 06:58, Pawel Laszczak wrote: Hi, Hi, Peter Chen writes: On 19-10-07 07:39:11, Pawel Laszczak wrote: Patch fixes issue with Halt Endnpoint Test observed %s/Endnpoint/Endpoint during using g_zero driver as DUT. Bug occurred only on some testing board. g_zero is l

RE: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Pawel Laszczak
Hi, > >Hi, > >Peter Chen writes: >> On 19-10-07 07:39:11, Pawel Laszczak wrote: >>> Patch fixes issue with Halt Endnpoint Test observed >> >> %s/Endnpoint/Endpoint >> >>> >>> during using g_zero >>> driver as DUT. Bug occurred only on some testing board. >> >> g_zero is legacy, please use configf

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Peter Chen
On 19-10-08 15:58:57, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On 19-10-07 07:39:11, Pawel Laszczak wrote: > >> Patch fixes issue with Halt Endnpoint Test observed > > > > %s/Endnpoint/Endpoint > > > >> > >> during using g_zero > >> driver as DUT. Bug occurred only on some testing

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Felipe Balbi
Hi, Peter Chen writes: > On 19-10-07 07:39:11, Pawel Laszczak wrote: >> Patch fixes issue with Halt Endnpoint Test observed > > %s/Endnpoint/Endpoint > >> >> during using g_zero >> driver as DUT. Bug occurred only on some testing board. > > g_zero is legacy, please use configfs function source_s

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Roger Quadros
Peter, On 08/10/2019 11:44, Peter Chen wrote: Endpoint can defer transition to Halted state if endpoint has pending requests. The implementation of halt handling is a little complicated, you may consider return -EAGAIN for functional stall through usb_ep_set_halt >from function driver if t

RE: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Peter Chen
> >> Endpoint can defer transition to Halted state if endpoint has pending > >> requests. > > > >The implementation of halt handling is a little complicated, you may > >consider return -EAGAIN for functional stall through usb_ep_set_halt > >from function driver if the requests are pending, it doe

RE: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-08 Thread Pawel Laszczak
Hi Peter, > >EXTERNAL MAIL > > >On 19-10-07 07:39:11, Pawel Laszczak wrote: >> Patch fixes issue with Halt Endnpoint Test observed > >%s/Endnpoint/Endpoint > >> >> during using g_zero >> driver as DUT. Bug occurred only on some testing board. > >g_zero is legacy, please use configfs function sourc

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-07 Thread Peter Chen
On 19-10-07 07:39:11, Pawel Laszczak wrote: > Patch fixes issue with Halt Endnpoint Test observed %s/Endnpoint/Endpoint > > during using g_zero > driver as DUT. Bug occurred only on some testing board. g_zero is legacy, please use configfs function source_sink or loopback instead. > > Endpoint

Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

2019-10-07 Thread Roger Quadros
On 07/10/2019 09:39, Pawel Laszczak wrote: Patch fixes issue with Halt Endnpoint Test observed during using g_zero driver as DUT. Bug occurred only on some testing board. Endpoint can defer transition to Halted state if endpoint has pending requests. Patch add additional condition that allows