RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-07 Thread Pawel Laszczak
You have right. It's the operator priority issue. I've made this condition as separate "if" statement as suggested by Greg. V2 has been posted. Pawel > > >On 21-03-05 06:10:59, Pawel Laszczak wrote: >> From: Pawel Laszczak >> >> The value "start_cycle ? 0 : 1" in assignment caused >> implici

Re: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-06 Thread Greg KH
On Sat, Mar 06, 2021 at 08:53:42AM +0800, Peter Chen wrote: > On 21-03-05 06:10:59, Pawel Laszczak wrote: > > From: Pawel Laszczak > > > > The value "start_cycle ? 0 : 1" in assignment caused > > implicit truncation whole value to 1 byte. > > To fix the issue, an explicit casting has been added.

Re: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-05 Thread Peter Chen
On 21-03-05 06:10:59, Pawel Laszczak wrote: > From: Pawel Laszczak > > The value "start_cycle ? 0 : 1" in assignment caused > implicit truncation whole value to 1 byte. > To fix the issue, an explicit casting has been added. The root cause for this issue should be operator "|" priority higher th

RE: [PATCH] usb: cdnsp: Fixes incorrect value in ISOC TRB

2021-03-04 Thread Pawel Laszczak
Hi, Please ignore this patch. I put incorrect address to Peter. I have sent again this patch with correct email address. >-Original Message- >From: Pawel Laszczak >Sent: Friday, March 5, 2021 6:00 AM >To: peter.c...@nxp.com >Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; >l