RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-24 Thread Winkler, Tomas
> > On Tue, 23 Oct 2018, Winkler, Tomas wrote: > > To the out label we jump after we are done with locality and cmd > > read() before we jump to locality 'locality'. We will need to add > > another variable to check If cmd_ready() was called or not in order to > > get rid of the extran label,

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-24 Thread Jarkko Sakkinen
On Tue, 23 Oct 2018, Winkler, Tomas wrote: To the out label we jump after we are done with locality and cmd read() before we jump to locality 'locality'. We will need to add another variable to check If cmd_ready() was called or not in order to get rid of the extran label, it's not internall

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-23 Thread Winkler, Tomas
Sent: Thursday, October 18, 2018 03:15 > >>>> To: Winkler, Tomas > >>>> Cc: Jarkko Sakkinen ; Jason > >>>> Gunthorpe ; Nayna Jain ; > >>>> Usyskin, Alexander ; Struk, Tadeusz > >>>> ; linux-integr...@vger.kernel.org; > &

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-23 Thread Jarkko Sakkinen
; Usyskin, Alexander ; Struk, Tadeusz ; linux-integr...@vger.kernel.org; linux-security- mod...@vger.kernel.org; linux-kernel@vger.kernel.org; sta...@vger.kernel.org Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow. On Tue, 16 Oct 2018, Tomas Winkler wrote: First, rename

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-20 Thread Winkler, Tomas
; Jason > >> Gunthorpe ; Nayna Jain ; > >> Usyskin, Alexander ; Struk, Tadeusz > >> ; linux-integr...@vger.kernel.org; > >> linux-security- mod...@vger.kernel.org; linux-kernel@vger.kernel.org; > >> sta...@vger.kernel.org > >> Subject: Re: [PATCH] tpm

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-19 Thread Jarkko Sakkinen
...@vger.kernel.org; linux-security- mod...@vger.kernel.org; linux-kernel@vger.kernel.org; sta...@vger.kernel.org Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow. On Tue, 16 Oct 2018, Tomas Winkler wrote: First, rename out_no_locality to out_locality for bailing out on both

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-17 Thread Winkler, Tomas
.@vger.kernel.org; linux-security- > mod...@vger.kernel.org; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Subject: Re: [PATCH] tpm: tpm_try_transmit() refactor error flow. > > On Tue, 16 Oct 2018, Tomas Winkler wrote: > > First, rename out_no_locality to out_local

Re: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-17 Thread Jarkko Sakkinen
On Tue, 16 Oct 2018, Tomas Winkler wrote: First, rename out_no_locality to out_locality for bailing out on both tpm_cmd_ready() and tpm_request_locality() failure. This is unnecessary change and technically it is not a rename: the commit message text and the code change do not match. Rename is