Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Tommi Rantala
On 28.11.2017 16:58, David Miller wrote: From: Tommi Rantala Date: Tue, 28 Nov 2017 14:53:15 +0200 - - if (unlikely(msg_user(hdr) == LINK_CONFIG)) { - err = tipc_udp_rcast_disc(b, skb); - if (err) - goto rcu_out; + } else { +

Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread David Miller
From: Tommi Rantala Date: Tue, 28 Nov 2017 14:53:15 +0200 > Call tipc_rcv() only if bearer is up in tipc_udp_recv(). > Fixes a rare TIPC div-by-zero crash in tipc_node_calculate_timer(): > > We're enabling a bearer, but it's not yet up and fully initialized. > At the same time we receive a disco

RE: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: Tommi Rantala [mailto:tommi.t.rant...@nokia.com] > Sent: Tuesday, November 28, 2017 07:53 > To: Jon Maloy ; Ying Xue > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org > Cc: Tomm