RE: [PATCH] sched: fix task and run queue run_delay inconsistencies

2015-10-01 Thread Meyer, Mike
> On Thu, Oct 01, 2015 at 08:37:32AM +0200, Peter Zijlstra wrote: > > > > On Wed, Sep 30, 2015 at 08:28:41PM +, Meyer, Mike wrote: > > It looks like the sites in the wakeup path do indeed not get any additional > conditionals. > > > > My only comment is I am not sure about the naming of the f

Re: [PATCH] sched: fix task and run queue run_delay inconsistencies

2015-10-01 Thread Peter Zijlstra
On Thu, Oct 01, 2015 at 08:37:32AM +0200, Peter Zijlstra wrote: > On Wed, Sep 30, 2015 at 08:28:41PM +, Meyer, Mike wrote: > > Yes that will also address the issue. > > > > The reason I approached the way I did was to avoid adding code path to > > the far more common uses of {en,de}queue_task

Re: [PATCH] sched: fix task and run queue run_delay inconsistencies

2015-09-30 Thread Peter Zijlstra
On Wed, Sep 30, 2015 at 08:28:41PM +, Meyer, Mike wrote: > > From: Peter Zijlstra [mailto:pet...@infradead.org] > > > > On Wed, Sep 23, 2015 at 12:37:18AM +, Meyer, Mike wrote: > > > > > > The proposed patch addresses the issue by calling > > > sched_info_reset_dequeued(thread) following th

RE: [PATCH] sched: fix task and run queue run_delay inconsistencies

2015-09-30 Thread Meyer, Mike
> From: Peter Zijlstra [mailto:pet...@infradead.org] > > On Wed, Sep 23, 2015 at 12:37:18AM +, Meyer, Mike wrote: > > > > The proposed patch addresses the issue by calling > > sched_info_reset_dequeued(thread) following the call to > > enqueue_task(rq, thread) for running threads in situations

Re: [PATCH] sched: fix task and run queue run_delay inconsistencies

2015-09-30 Thread Peter Zijlstra
On Wed, Sep 23, 2015 at 12:37:18AM +, Meyer, Mike wrote: > During evaluation of some performance data, it was discovered thread > and run queue run_delay accounting data was inconsistent with the other > accounting data that was collected. Further investigation found under > certain circumstan