> > Ideally s2io_reset should
> > return a failure in this case (return is void now)
>
> Would you care to provide a patch that did this? I could
> experiment a bit, and try to do this myself; but I really
> don't know this hardware, or this driver, that well.
[Ram] Yes, I can submit a patch to ad
On Mon, Mar 05, 2007 at 05:33:39PM -0500, Ramkrishna Vepa wrote:
> Comments on this patch -
>
> 1. device_close_flag is unused and is not required.
I'll submit a patch to strip this out sometime next week.
> 2. s2io_reset can fail to reset the device.
I thought I'd seen this occasionally, and
nel.org; Jeff Garzik;
Andrew
> Morton
> Subject: RE: [PATCH] s2io: add PCI error recovery support
>
> Comments on this patch -
>
> 1. device_close_flag is unused and is not required.
> > +static pci_ers_result_t s2io_io_error_detected(struct pci_dev
*pdev,
> > +
Comments on this patch -
1. device_close_flag is unused and is not required.
> +static pci_ers_result_t s2io_io_error_detected(struct pci_dev *pdev,
> + pci_channel_state_t
state)
> +{
...
> + do_s2io_card_down(sp, 0);
> +
Linas,
We reviewed this patch and it looks good.
Thanks,
Ram
> > -Original Message-
> > From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> > On Behalf Of Linas Vepstas
> > Sent: Tuesday, October 24, 2006 2:55 PM
> > To: Raghavendra Koushik; Ananda Raju; Wen Xiong
> > Cc: linux-kernel@vge
5 matches
Mail list logo
