Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-08-06 Thread Mihai Donțu
18 7:17 PM > > > To: Kees Cook > > > Cc: LKML; Andy Shevchenko; Platform Driver; Mihai Donțu; Limonciello, > > > Mario > > > Subject: Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc > > > > > > On Wed, Jun 20, 2018 at 04:

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-22 Thread Darren Hart
iver; Mihai Donțu; Limonciello, Mario > > Subject: Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc > > > > On Wed, Jun 20, 2018 at 04:43:14PM -0700, Kees Cook wrote: > > > On Wed, Jun 20, 2018 at 4:37 PM, Darren Hart wrote: > > > > On Wed, Jun 20, 2018

RE: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Wednesday, June 20, 2018 7:17 PM > To: Kees Cook > Cc: LKML; Andy Shevchenko; Platform Driver; Mihai Donțu; Limonciello, Mario > Subject: Re: [PATCH] platform/x86: wmi: Do not mix pages and k

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Darren Hart
On Wed, Jun 20, 2018 at 04:43:14PM -0700, Kees Cook wrote: > On Wed, Jun 20, 2018 at 4:37 PM, Darren Hart wrote: > > On Wed, Jun 20, 2018 at 02:31:41PM -0700, Kees Cook wrote: > >> The probe handler_data was being allocated with __get_free_pages() > >> for no reason I could find. The error path wa

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Kees Cook
On Wed, Jun 20, 2018 at 4:37 PM, Darren Hart wrote: > On Wed, Jun 20, 2018 at 02:31:41PM -0700, Kees Cook wrote: >> The probe handler_data was being allocated with __get_free_pages() >> for no reason I could find. The error path was using kfree(). Since > > v4 of Mario's series used kmalloc: > htt

Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Darren Hart
On Wed, Jun 20, 2018 at 02:31:41PM -0700, Kees Cook wrote: > The probe handler_data was being allocated with __get_free_pages() > for no reason I could find. The error path was using kfree(). Since v4 of Mario's series used kmalloc: https://patchwork.kernel.org/patch/9985827/ This was changed in