RE: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Tianxianting
..@kernel.org] > Sent: Monday, September 21, 2020 11:08 PM > To: tianxianting (RD) > Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; > linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] nvme: replace meaningless judgement by checking > whe

Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Keith Busch
8 PM > To: tianxianting (RD) > Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; > linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] nvme: replace meaningless judgement by checking whether > req is null > > On Mon, Sep 21, 2020 at 10:10:52AM +0800, Xiantin

RE: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Tianxianting
, 2020 11:08 PM To: tianxianting (RD) Cc: ax...@fb.com; h...@lst.de; s...@grimberg.me; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null On Mon, Sep 21, 2020 at 10:10:52AM +0800, Xianting Tian w

Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-21 Thread Keith Busch
On Mon, Sep 21, 2020 at 10:10:52AM +0800, Xianting Tian wrote: > @@ -940,13 +940,6 @@ static inline void nvme_handle_cqe(struct nvme_queue > *nvmeq, u16 idx) > struct nvme_completion *cqe = &nvmeq->cqes[idx]; > struct request *req; > > - if (unlikely(cqe->command_id >= nvmeq->q_d

Re: [PATCH] nvme: replace meaningless judgement by checking whether req is null

2020-09-20 Thread Christoph Hellwig
Thanks, this looks much more sensible than the previous versions.