Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-22 Thread Keith Busch
On Wed, Feb 20, 2019 at 06:46:11PM +0900, Takao Indoh wrote: > On Thu, Feb 14, 2019 at 08:44:48PM +, Elliott, Robert (Persistent Memory) > wrote: > > * how does this interact with an iommu, if there is one? Must the > > address with bit 56 also be granted permission, or is that > > stripped o

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-20 Thread Takao Indoh
AM > > To: Takao Indoh > > Cc: Takao Indoh ; s...@grimberg.me; > > linux-kernel@vger.kernel.org; linux- > > n...@lists.infradead.org; ax...@fb.com; h...@lst.de > > Subject: Re: [PATCH] nvme: Enable acceleration feature of A64FX processor > > > > On Tue, F

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-14 Thread Keith Busch
On Thu, Feb 14, 2019 at 12:44:48PM -0800, Elliott, Robert (Persistent Memory) wrote: > > The PCIe and NVMe specifications dosn't standardize a way to tell the device > when to use RO, which leads to system workarounds like this. > > The Enable Relaxed Ordering bit defined by PCIe tells the devic

RE: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-14 Thread Elliott, Robert (Persistent Memory)
@lists.infradead.org; ax...@fb.com; h...@lst.de > Subject: Re: [PATCH] nvme: Enable acceleration feature of A64FX processor > > On Tue, Feb 05, 2019 at 09:56:05PM +0900, Takao Indoh wrote: > > On Fri, Feb 01, 2019 at 07:54:14AM -0700, Keith Busch wrote: > > > On Fri, Feb

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-14 Thread Christoph Hellwig
On Wed, Feb 13, 2019 at 09:03:58PM +0900, Takao Indoh wrote: > Ok, let me think about how I should change this patch. Just drop it. > I'm thinking that the problem of this patch is adding processor specific > code into NVMe common driver, is this correct? Or another problem? It > would be great i

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-13 Thread Takao Indoh
On Tue, Feb 05, 2019 at 05:13:47PM +0100, Christoph Hellwig wrote: > On Tue, Feb 05, 2019 at 07:39:06AM -0700, Keith Busch wrote: > > > Standard PCIe devices can use Relaxed Ordering (RO) by setting Attr > > > field in the TLP header, however, this mechanism cannot be utilized if > > > the device d

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-05 Thread Christoph Hellwig
On Tue, Feb 05, 2019 at 07:39:06AM -0700, Keith Busch wrote: > > Standard PCIe devices can use Relaxed Ordering (RO) by setting Attr > > field in the TLP header, however, this mechanism cannot be utilized if > > the device does not support RO feature. Fujitsu A64FX processor has an > > alternate fe

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-05 Thread Keith Busch
On Tue, Feb 05, 2019 at 09:56:05PM +0900, Takao Indoh wrote: > On Fri, Feb 01, 2019 at 07:54:14AM -0700, Keith Busch wrote: > > On Fri, Feb 01, 2019 at 09:46:15PM +0900, Takao Indoh wrote: > > > From: Takao Indoh > > > > > > Fujitsu A64FX processor has a feature to accelerate data transfer of > >

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-05 Thread Takao Indoh
On Fri, Feb 01, 2019 at 04:51:20PM +0100, Christoph Hellwig wrote: > On Fri, Feb 01, 2019 at 09:46:15PM +0900, Takao Indoh wrote: > > From: Takao Indoh > > > > Fujitsu A64FX processor has a feature to accelerate data transfer of > > internal bus by relaxed ordering. It is enabled when the bit 56

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-05 Thread Takao Indoh
On Fri, Feb 01, 2019 at 07:54:14AM -0700, Keith Busch wrote: > On Fri, Feb 01, 2019 at 09:46:15PM +0900, Takao Indoh wrote: > > From: Takao Indoh > > > > Fujitsu A64FX processor has a feature to accelerate data transfer of > > internal bus by relaxed ordering. It is enabled when the bit 56 of dma

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-01 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 09:46:15PM +0900, Takao Indoh wrote: > From: Takao Indoh > > Fujitsu A64FX processor has a feature to accelerate data transfer of > internal bus by relaxed ordering. It is enabled when the bit 56 of dma > address is set to 1. > > This patch introduces this acceleration fe

Re: [PATCH] nvme: Enable acceleration feature of A64FX processor

2019-02-01 Thread Keith Busch
On Fri, Feb 01, 2019 at 09:46:15PM +0900, Takao Indoh wrote: > From: Takao Indoh > > Fujitsu A64FX processor has a feature to accelerate data transfer of > internal bus by relaxed ordering. It is enabled when the bit 56 of dma > address is set to 1. Wait, what? RO is a standard PCIe TLP attribut