Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-22 Thread Paul Bolle
On Mon, 2013-07-22 at 02:07 +, Peng, Tao wrote: > Paul Bolle [mailto:pebo...@tiscali.nl] > > I ask because I noticed that "drivers/staging/lustre/lustre/ptlrpc/gss/" > > is only built if CONFIG_PTLRPC_GSS is set. But the corresponding Kconfig > > symbol is nowhere to be found. > > > That's my

RE: [PATCH] lustre:libcfs: remove redundant code.

2013-07-21 Thread Peng, Tao
> -Original Message- > From: Paul Bolle [mailto:pebo...@tiscali.nl] > Sent: Saturday, July 20, 2013 12:07 AM > To: Greg Kroah-Hartman > Cc: Alexandru Juncu; Pekka Enberg; andreas.dilger; Peng, Tao; driverdev; LKML > Subject: Re: [PATCH] lustre:libcfs: remove redundant

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Greg Kroah-Hartman
On Fri, Jul 19, 2013 at 06:29:34PM +0300, Alexandru Juncu wrote: > On 19 July 2013 18:21, Pekka Enberg wrote: > > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: > >> I was thinking the same thing, but I hesitated because I didn't know > >> how used it was and I didn't want to break somet

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Alexandru Juncu
On 19 July 2013 19:07, Paul Bolle wrote: > On Fri, 2013-07-19 at 08:46 -0700, Greg Kroah-Hartman wrote: >> Doesn't matter, if there are no users, please just remove it. > > Is that, basically, your approach to staging cleanups? > > I ask because I noticed that "drivers/staging/lustre/lustre/ptlrpc

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Daniel Baluta
On Fri, Jul 19, 2013 at 6:46 PM, Greg Kroah-Hartman wrote: > On Fri, Jul 19, 2013 at 06:29:34PM +0300, Alexandru Juncu wrote: >> On 19 July 2013 18:21, Pekka Enberg wrote: >> > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: >> >> I was thinking the same thing, but I hesitated because I

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Paul Bolle
On Fri, 2013-07-19 at 08:46 -0700, Greg Kroah-Hartman wrote: > Doesn't matter, if there are no users, please just remove it. Is that, basically, your approach to staging cleanups? I ask because I noticed that "drivers/staging/lustre/lustre/ptlrpc/gss/" is only built if CONFIG_PTLRPC_GSS is set. B

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Alexandru Juncu
On 19 July 2013 18:21, Pekka Enberg wrote: > On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: >> I was thinking the same thing, but I hesitated because I didn't know >> how used it was and I didn't want to break something. > > "git grep cfs_strdup" suggests that nobody uses it so you could

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Pekka Enberg
On Fri, Jul 19, 2013 at 6:13 PM, Alexandru Juncu wrote: > I was thinking the same thing, but I hesitated because I didn't know > how used it was and I didn't want to break something. "git grep cfs_strdup" suggests that nobody uses it so you could just remove it completely... -- To unsubscribe fro

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Alexandru Juncu
On 19 July 2013 18:08, Pekka Enberg wrote: > On Fri, Jul 19, 2013 at 5:45 PM, Alexandru Juncu wrote: >> Found using coccinelle. It suggested kmalloc/strcpy should be replaced >> with kstrdup, but the entire function can be replaced by kstrdup. >> >> Signed-off-by: Alexandru Juncu >> --- >> driv

Re: [PATCH] lustre:libcfs: remove redundant code.

2013-07-19 Thread Pekka Enberg
On Fri, Jul 19, 2013 at 5:45 PM, Alexandru Juncu wrote: > Found using coccinelle. It suggested kmalloc/strcpy should be replaced > with kstrdup, but the entire function can be replaced by kstrdup. > > Signed-off-by: Alexandru Juncu > --- > drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 1