Re: RE: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-22 Thread Eunbong Song
> If your patch is applied, the data which is compressed > by your big-endian system won't be decompressed in other little-endian system. I can't understand this. Please, could you explain this more ? My patch just replaces put_unaligned with put_unaligned_le16. and this just write compression

Re: RE: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-22 Thread Eunbong Song
Hello. >Can you check if this patch fix your problem also? Unfortunately your patch does not fix my problem. My test logs are as follow. I did the same test with lzo compression algorithm and with my patch, and these work well. debug_shell:/user> echo 1 > /sys/block/zram0/reset debug_shell:/us

Re: Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-21 Thread Eunbong Song
> So it's never worked? Yes, it's always failed to mount. > Did you test on a little endian machine after making this change? Unfortunately, i don't have little endian machine. So i couldn't test that. Additionaly, when lz4 compress calls lz4_compressctx() function and uses LZ4_WRITE_LITTLEENDI

Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-21 Thread Greg KH
On Tue, Jul 22, 2014 at 02:17:52AM +, Eunbong Song wrote: > > > Odd line wrapping :( > > Sorry, for this. > > > Anyway, is this a new problem? Or something that has always been there > > in this compression function? > > Actually, i have tested zram with lz4 functions in my board(mips64 b

Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-21 Thread Eunbong Song
> Odd line wrapping :( Sorry, for this. > Anyway, is this a new problem? Or something that has always been there > in this compression function? Actually, i have tested zram with lz4 functions in my board(mips64 big endian). Everytime i try to mount my ext4 zram image i have failed. After

Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put_unaligned

2014-07-21 Thread Greg KH
On Tue, Jul 22, 2014 at 02:03:22AM +, Eunbong Song wrote: > > In case of mips bigendian machine, put_unaligned writes bigendian bytes > order. > This is defined in arch/mips/include/asm/unaligned.h. So it's right use > put_unaligned_le16 function instead of put_unaligned. > This patch also