RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-20 Thread Konstantin Komarov
> From: David Sterba > Sent: Friday, August 14, 2020 4:41 PM > On Fri, Aug 14, 2020 at 12:29:01PM +, Konstantin Komarov wrote: > > This patch adds NTFS Read-Write driver to fs/ntfs3. > > > > Having decades of expertise in commercial file systems development and huge > > test coverage, we at Pa

RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-20 Thread Konstantin Komarov
From: David Sterba Sent: Friday, August 14, 2020 4:41 PM > In case somebody wants to compile it, this fixup is needed to let 'make > fs/ntfs3/' actually work, besides enabling it in the config. > > diff --git a/fs/Makefile b/fs/Makefile > index 1c7b0e3f6daa..b0b4ad8affa0 100644 > --- a/fs/Makefil

RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-20 Thread Konstantin Komarov
From: David Sterba Sent: Saturday, August 15, 2020 10:07 PM > > 1. check existing support in kernel > > There is fs/ntfs with read-only support from Tuxera, last change in the > git tree is 3 years ago. The driver lacks read-write support so there's > not 100% functionality duplication but there

RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-20 Thread Konstantin Komarov
From: Aurélien Aptel Sent: Friday, August 14, 2020 6:30 PM > I've tried this using libntfs-3g mkfs.ntfs > > # mkfs.ntfs /dev/vb1 > # mount -t ntfs3 /dev/vb1 /mnt > > This already triggered UBSAN: > Then I've tried to copy /etc into it: > ... > # cp -rp /etc /mnt > > But this triggered a NULL pt

RE: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-20 Thread Konstantin Komarov
From: Aurélien Aptel Sent: Friday, August 14, 2020 5:09 PM > > Hi Konstantin, > > That's cool :) As Nikolay said it needs a little change to the makefiles > to even build. > > Are you also going to publish your own mkfs.ntfs3 tool? I dont think the > existing one would support 64k clusters. Hi

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-16 Thread Pali Rohár
On Friday 14 August 2020 12:29:01 Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source Communit

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-15 Thread Matthew Wilcox
On Sat, Aug 15, 2020 at 09:06:42PM +0200, David Sterba wrote: > There's maybe more I missed, but hopefully HTH. One thing you missed is adding support to fstests git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git If it passes that torture test, I think we can have confidence that this is a real

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-15 Thread David Sterba
On Fri, Aug 14, 2020 at 12:29:01PM +, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-14 Thread Aurélien Aptel
I've tried this using libntfs-3g mkfs.ntfs # mkfs.ntfs /dev/vb1 # mount -t ntfs3 /dev/vb1 /mnt This already triggered UBSAN: UBSAN: object-size-mismatch in fs/ntfs3/super.c:834:16 load of address 6ae096b

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-14 Thread Aurélien Aptel
Hi Konstantin, That's cool :) As Nikolay said it needs a little change to the makefiles to even build. Are you also going to publish your own mkfs.ntfs3 tool? I dont think the existing one would support 64k clusters. I would recommend to run checkpatch (I see already 87 warnings... some of it is

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-14 Thread David Sterba
On Fri, Aug 14, 2020 at 12:29:01PM +, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-14 Thread Nikolay Borisov
On 14.08.20 г. 15:29 ч., Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source Community by p