On 23-05-18, 10:40, Russell King - ARM Linux wrote:
> On Wed, May 23, 2018 at 12:05:24PM +0300, Ilia Lin wrote:
> > + np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> > + if (IS_ERR(np))
> > + return PTR_ERR(np);
> ...
> > +
> > + pdev = platform_device_register_simple("cpufreq-dt",
On Wed, May 23, 2018 at 12:05:24PM +0300, Ilia Lin wrote:
> + np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> + if (IS_ERR(np))
> + return PTR_ERR(np);
...
> +
> + pdev = platform_device_register_simple("cpufreq-dt", -1, NULL, 0);
> + if (!IS_ERR(pdev))
Do you need to
On 23-05-18, 12:05, Ilia Lin wrote:
> In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors,
> the CPU frequency subset and voltage value of each OPP varies
> based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables
> defines the voltage and frequency value bas
On 22-05-18, 14:07, Sudeep Holla wrote:
> On Tue, May 22, 2018 at 02:29:45PM +0300, Ilia Lin wrote:
> > In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors,
> > the CPU frequency subset and voltage value of each OPP varies
> > based on the silicon variant in use. Qualcomm Proces
On Tue, May 22, 2018 at 02:29:45PM +0300, Ilia Lin wrote:
> In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors,
> the CPU frequency subset and voltage value of each OPP varies
> based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables
> defines the voltage a
On 22-05-18, 10:59, ilia...@codeaurora.org wrote:
> OK, I think I found out the way. Would this be correct?
> ---
> extern struct cpu_topology cpu_topology[NR_CPUS];
>
> static struct device *qcom_cpufreq_k
On 22/05/18 08:59, ilia...@codeaurora.org wrote:
> OK, I think I found out the way. Would this be correct?
No.
> ---
> extern struct cpu_topology cpu_topology[NR_CPUS];
>
> static struct device *qcom_cp
On 22/05/18 07:56, ilia...@codeaurora.org wrote:
>
>
>> -Original Message-
>> From: Sudeep Holla
>> Sent: Monday, May 21, 2018 16:05
[...]
>>
>>
>> That may be true and I am not that bothered about it. But assuming physical
>> ordering from the logical cpu number is *incorrect* and w
27;linux-arm-
> m...@vger.kernel.org' ; 'linux-
> s...@vger.kernel.org' ; 'linux-arm-
> ker...@lists.infradead.org' ;
> 'rna...@codeaurora.org' ;
> 'amit.kuche...@linaro.org' ;
> 'nicolas.deche...@linaro.org' ;
> 'cel
el.org; linux-...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; rna...@codeaurora.org;
> amit.kuche...@linaro.org; nicolas.deche...@linaro.org;
> cels...@codeaurora.org; tfin...@codeaurora.org
> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver
>
>
&
On 21/05/18 13:57, ilia...@codeaurora.org wrote:
>
[...]
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +#include
>>> +
>>> +#define MSM_ID_SMEM137
>>> +#define SILVER_LEAD
linux-...@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; rna...@codeaurora.org;
> amit.kuche...@linaro.org; nicolas.deche...@linaro.org;
> cels...@codeaurora.org; tfin...@codeaurora.org
> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver
>
>
>
> On 1
On 19/05/18 12:35, Ilia Lin wrote:
> In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors,
> the CPU frequency subset and voltage value of each OPP varies
> based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables
> defines the voltage and frequency value ba
On Mon, May 21, 2018 at 03:35:07PM +0300, ilia...@codeaurora.org wrote:
> There are 2 CPU clusters in the Kryo, CPU 0 and 1 are called Silver Cluster
> and CPU 2 and 3 - Gold Cluster. Each cluster has single clock. The clusters
> differ in terms of speed capabilities, computing power and power
> co
org; linux-
> p...@vger.kernel.org; linux-arm-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> c...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver
>
> On Mon, May 2
ay 21, 2018 13:54
> > To: Ilia Lin
> > Cc: viresh.ku...@linaro.org; devicet...@vger.kernel.org; linux-
> > p...@vger.kernel.org; linux-arm-...@vger.kernel.org; linux-
> > ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> > c...@vger.kernel.org; linux-arm-ker.
org; linux-
> p...@vger.kernel.org; linux-arm-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> c...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH] cpufreq: Add Kryo CPU scaling driver
>
> On Mon, May 21, 2018 at 01:31:30PM +0
On Mon, May 21, 2018 at 01:31:30PM +0300, Ilia Lin wrote:
> +#define SILVER_LEAD 0
> +#define GOLD_LEAD2
Okay, two different values here, but "GOLD_LEAD" appears unused.
> + cpu_dev_silver = get_cpu_device(SILVER_LEAD);
> + if (NULL == cpu_dev_silver)
> + return -ENODEV;
Would have been better if you would have updated the subject as:
[PATCH v10 10/15] cpufreq: Add Kryo CPU scaling driver
On 21-05-18, 13:31, Ilia Lin wrote:
> In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors,
> the CPU frequency subset and voltage value of each OPP varies
>
More comments after Russell's reply.
On 19-05-18, 14:35, Ilia Lin wrote:
> +static int __init qcom_cpufreq_kryo_driver_init(void)
> +{
> + struct device *cpu_dev_silver, *cpu_dev_gold;
> + struct opp_table *opp_silver, *opp_gold;
> + enum _msm8996_version msm8996_version;
> + struc
20 matches
Mail list logo
