On Wed, Nov 18, 2015 at 04:26:52PM +, Ian Abbott wrote:
> >+#define DMM32AT_AI_CFG_SCINT_10US (BIT(5) & ~BIT(4))
> >+#define DMM32AT_AI_CFG_SCINT_5US(BIT(5) | BIT(4))
>
> The values of DMM32AT_AI_CFG_SCINT_20US etc. are numerically
> correct, but look a bit strange. The `(BIT(5) & ~BIT(
On 18/11/15 16:26, Ian Abbott wrote:
On 14/11/15 17:10, Ranjith Thangavel wrote:
BIT macro is used for defining BIT location instead of
shifting operator, usleep_range is preferred over
udelay - coding style issue
Those two things should be done in separate patches.
Sorry, I didn't see you'v
On 14/11/15 17:10, Ranjith Thangavel wrote:
BIT macro is used for defining BIT location instead of
shifting operator, usleep_range is preferred over
udelay - coding style issue
Those two things should be done in separate patches.
Signed-off-by: Ranjith Thangavel
---
drivers/staging/comedi/
On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
> drivers/staging/comedi/drivers/dmm32at.c |4 +
This one is buggy. For example:
> -#define DMM32AT_FIFO_STATUS_PAGE_MASK(3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK0
There are other bugs as well. Please, be more careful.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
5 matches
Mail list logo
