Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-12 Thread Ian Abbott
On 11/11/15 15:54, Ranjith Thangavel wrote: BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/comedi_parport.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott
On 11/11/15 14:18, Ranjith T wrote: Actually my name is Ranjith and father name is Thangavel. So I used to mention my name as Ranjith T. How do you write your name on legal documents? That is what you should use on the patch's "Signed-off-by:" line, and on the email's "From:" line. Thanks.

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T
Actually my name is Ranjith and father name is Thangavel. So I used to mention my name as Ranjith T. Thanks, Ranjith T On Wed, Nov 11, 2015 at 7:41 PM, Ian Abbott wrote: > On 11/11/2015 13:44, Ranjith T wrote: >> >> Is this patch is fine?. >> >> Thanks, >> Ranjith T. > > > Fine apart from the "

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ian Abbott
On 11/11/2015 13:44, Ranjith T wrote: Is this patch is fine?. Thanks, Ranjith T. Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't really "T". On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T wrote: BIT macro is used for defining BIT location instead of shifting oper

Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-11 Thread Ranjith T
Is this patch is fine?. Thanks, Ranjith T. On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith T > --- > drivers/staging/comedi/drivers/comedi_parport.c |4 ++-- > 1 f

RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

2015-11-09 Thread Hartley Sweeten
On Monday, November 09, 2015 8:17 AM, Ranjith wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith > --- > drivers/staging/comedi/drivers/comedi_parport.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)