Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread John Anthony Kazos Jr.
On Fri, 20 Apr 2007, Andrew Morton wrote: > On Fri, 20 Apr 2007 16:20:59 -0400 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-04-20 at 12:30 -0700, Andrew Morton wrote: > > > On Fri, 20 Apr 2007 14:50:06 -0400 > > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > > > > CONF

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread Andrew Morton
On Fri, 20 Apr 2007 16:20:59 -0400 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2007-04-20 at 12:30 -0700, Andrew Morton wrote: > > On Fri, 20 Apr 2007 14:50:06 -0400 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > > CONFIG_LBD=y gives us an additional 3kb of instructions on i386

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
On Fri, 2007-04-20 at 12:30 -0700, Andrew Morton wrote: > On Fri, 20 Apr 2007 14:50:06 -0400 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > CONFIG_LBD=y gives us an additional 3kb of instructions on i386 > > > allnoconfig. Other architectures might do less well. It's not a huge > > > diffe

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread Andrew Morton
On Fri, 20 Apr 2007 14:50:06 -0400 James Bottomley <[EMAIL PROTECTED]> wrote: > > CONFIG_LBD=y gives us an additional 3kb of instructions on i386 > > allnoconfig. Other architectures might do less well. It's not a huge > > difference, but that's the way in which creeping bloatiness happens. > >

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
lto:[EMAIL PROTECTED] > > > > Sent: Thu 4/19/2007 11:22 AM > > > > To: Miller, Mike (OS Dev) > > > > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED]; > > > > linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve > > > >

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread Andrew Morton
a 2nd time. > > > > > > -- steve > > > > > > -Original Message- > > > From: James Bottomley [mailto:[EMAIL PROTECTED] > > > Sent: Thu 4/19/2007 11:22 AM > > > To: Miller, Mike (OS Dev) > > > Cc: Hisashi Hifumi; [EMAIL

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread Alan Cox
> > #if (BITS_PER_LONG > 32) || defined(CONFIG_LBD) > > #define sector_upper_32(sector) ((sector) >> 32) > > #else > > #define sector_upper_32(sector) (0) > > #endif Gak Just do sector_upper_32(sector) (((sector) >> 31) >> 1) and lose all the ifdefs, Alan - To unsubscribe from this l

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-20 Thread James Bottomley
ent: Thu 4/19/2007 11:22 AM > > To: Miller, Mike (OS Dev) > > Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED]; > > linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve > > Subject: RE: [PATCH] cciss: Fix warnings during compilation under > > 3

Re: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Andrew Morton
ernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve > Subject: RE: [PATCH] cciss: Fix warnings during compilation under > 32bitenvironment > > On Thu, 2007-04-19 at 16:12 +, Miller, Mike (OS Dev) wrote: > > > > Nak. You still haven't told where you saw these

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Cameron, Steve
Thu 4/19/2007 11:22 AM To: Miller, Mike (OS Dev) Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve Subject: RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment On Thu, 2007-04-19 at 16:12 +, Miller,

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Miller, Mike (OS Dev)
, Steve > Subject: RE: [PATCH] cciss: Fix warnings during compilation > under 32bitenvironment > > On Thu, 2007-04-19 at 16:12 +, Miller, Mike (OS Dev) wrote: > > > > Nak. You still haven't told where you saw these warnings. What > > > > compiler