RE: [PATCH] Tools: hv: Fix for long file names from readdir

> -Original Message- > From: Tomas Hozza [mailto:tho...@redhat.com] > Sent: Friday, November 09, 2012 7:47 AM > To: o...@aepfle.de; KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com; > Toma

RE: [PATCH] Tools: hv: Fix for long file names from readdir

m; KY > Srinivasan > Subject: Re: [PATCH] Tools: hv: Fix for long file names from readdir > > > > -char dev_id[256]; > > > +char dev_id[512]; > > > > Shouldnt that be PATH_MAX or similar? > > dirent->d_name should be PATH_MAX, but it is m

Re: [PATCH] Tools: hv: Fix for long file names from readdir

> > -char dev_id[256]; > > +char dev_id[512]; > > Shouldnt that be PATH_MAX or similar? dirent->d_name should be PATH_MAX, but it is mostly not guaranteed. And then the dev_id is concatenated with two strings so it can exceed 256 bytes. After discussion with K. Y. Srinivasan I j

Re: [PATCH] Tools: hv: Fix for long file names from readdir

On Thu, Nov 08, Tomas Hozza wrote: > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > sized buffers which could be too small to store really long names. > - char dev_id[256]; > + char dev_id[512]; Shouldnt that be PATH_MAX or similar? Olaf -- To unsubscribe from thi