RE: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-16 Thread Tom Joseph
Hi Kishon, > -Original Message- > From: Kishon Vijay Abraham I > Sent: 15 October 2019 12:23 > To: Tom Joseph ; linux-...@vger.kernel.org > Cc: Lorenzo Pieralisi ; Bjorn Helgaas > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] PCI:cadence:Driver refactored to

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-15 Thread Kishon Vijay Abraham I
Hi Tom, On 01/10/19 4:45 PM, Kishon Vijay Abraham I wrote: > Hi Tom, > > On 30/09/19 10:12 PM, Tom Joseph wrote: >> All the platform related APIs/Structures in the driver has been extracted >> out to a separate file (pcie-cadence-plat.c). This will enable the >> driver to be used as a core libr

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-07 Thread Andrew Murray
On Tue, Oct 01, 2019 at 04:49:12PM -0500, Bjorn Helgaas wrote: > On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote: > > Hi Tom, > > > > Thanks for the patch. > > > > I'd suggest that you rename the subject of this series to "PCI: cadence: > > ..." > > to be consistent with the existi

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Bjorn Helgaas
On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote: > Hi Tom, > > Thanks for the patch. > > I'd suggest that you rename the subject of this series to "PCI: cadence: ..." > to be consistent with the existing commit history, e.g. git log > --oneline drivers/pci/controller/pcie-cadence*

RE: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Tom Joseph
nce:Driver refactored to use as a core library. > > EXTERNAL MAIL > > > Hi Tom, > > Thanks for the patch. > > I'd suggest that you rename the subject of this series to "PCI: cadence: ..." > to be consistent with the existing commit history, e.g. git

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Kishon Vijay Abraham I
Hi Tom, On 30/09/19 10:12 PM, Tom Joseph wrote: > All the platform related APIs/Structures in the driver has been extracted > out to a separate file (pcie-cadence-plat.c). This will enable the > driver to be used as a core library, which could be used by other > platform drivers.Testing was don

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Andrew Murray
On Tue, Oct 01, 2019 at 04:08:45PM +0530, Kishon Vijay Abraham I wrote: > Hi Andrew Murray, > > On 01/10/19 3:37 PM, Andrew Murray wrote: > > Hi Tom, > > > > Thanks for the patch. > > > > I'd suggest that you rename the subject of this series to "PCI: cadence: > > ..." > > to be consistent with

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Kishon Vijay Abraham I
Hi Andrew Murray, On 01/10/19 3:37 PM, Andrew Murray wrote: > Hi Tom, > > Thanks for the patch. > > I'd suggest that you rename the subject of this series to "PCI: cadence: ..." > to be consistent with the existing commit history, e.g. git log > --oneline drivers/pci/controller/pcie-cadence* -

Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

2019-10-01 Thread Andrew Murray
Hi Tom, Thanks for the patch. I'd suggest that you rename the subject of this series to "PCI: cadence: ..." to be consistent with the existing commit history, e.g. git log --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you don't need a full stop at the end, and you ought t